Re: SMPP getting stuck

before submitting ANY patch to CVS it should be checked if the code 
compiles at least...

With current cvs I get:

gcc -D_REENTRANT=1 -I. -Igw -g -O2 -DBROKEN_PTHREADS=1 
-I/usr/include/libxml -I/usr/include -I/usr/include/mysql -o 
gw/smsc/smsc_smpp.o -c gw/smsc/smsc_smpp.c
gw/smsc/smsc_smpp.c: In function `handle_pdu':
gw/smsc/smsc_smpp.c:684: parse error before `int'
gw/smsc/smsc_smpp.c:997: `cmd_stat' undeclared (first use in this 
function)
gw/smsc/smsc_smpp.c:997: (Each undeclared identifier is reported only 
once
gw/smsc/smsc_smpp.c:997: for each function it appears in.)
make: *** [gw/smsc/smsc_smpp.o] Error 1

the fix is to remove the line

resp = NULL;

and to initialize the variable resp to NULL a few lines above.

and then when running bearerbox I get:

2003-01-02 08:29:22 [0] PANIC: Trying to fetch variable 
`wait-ack-expire' in group `smsc', not allowed.


I'm fixing it for you now in CVS...



On Donnerstag, Januar 2, 2003, at 12:26  Uhr, Stipe Tolj wrote:

> Nisan Bloch wrote:
>>
>> Here is a different take the Andreas's SMPP generic_nack patch. This 
>> is a
>> bit more complete, and fixes a potential NULL pointer exception in the
>> code.  On line 922 a check is made for msg==NULL, and an error message
>> outputed, but then bb_smscconn_send_failed is called with the NULL 
>> msg.
>>
>> This patch is quite different so I have attached the changed case, 
>> rather
>> than a diff.
>
> changed applied to cvs. Thanks Nisan.
>
> Stipe
>
> [email protected]
> -------------------------------------------------------------------
> Wapme Systems AG
>
> Vogelsanger Weg 80
> 40470 Düsseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [email protected]
> Internet: http://www.wapme-systems.de
> -------------------------------------------------------------------
> wapme.net - wherever you are
>
>
Andreas Fink
Global Networks Switzerland AG

------------------------------------------------------------------
Tel: +41-61-6666333  Fax: +41-61-6666334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/      [email protected]
------------------------------------------------------------------
Member of the GSM Association