RE: Notice of issue in SMPP Driver

Hi
At 12:37 PM 1/22/03 +0000, Michael Mulcahy wrote:
>Hi,
>
>The approach I have taken is to set the status to be SMSCCONN_RECONNECTING
>when either
>the transmitter or receiver go down. This allows an administrator to see the
>problem
>immediately. Plus I did not want to make changes to the SMSCConn module for
>just the
>SMPP driver.


We have a patch running that is done quite differently. We have added two 
elements to the SMPP structure; transmitter_status (also used for 
transceiver) and receiver_status. We then change these variables depending 
on the status of the various components.  We have also added smscconn 
states SMSCCONN_ACTIVE_RECV and SMSCCONN_ACTIVE_TRANS. We have modified the 
status page to show connecting if both connections down, receiver if 
running as a receiver and transmitter if transmitter only and online if both.

This allows us for example to run a transmitter or receiver only 
connection. (yes one of our providers insisted that we bind with 
essentially 2 different sets of account details, one instance transmitter 
only and the other receiver only).

Nisan

>Any comments or suggestions?
>
>Michael.
>
>ANAM Wireless Internet Solutions
>http://www.anam.com mailto:[email protected]
>+353 1 284 7555
>Castle Yard, Saint Patrick's Road, Dalkey, County Dublin, Ireland
>
> > -----Original Message-----
> > From: Indrek Mandre [mailto:[email protected]]
> > Sent: 21 January 2003 17:40
> > To: [email protected]
> > Cc: [email protected]
> > Subject: Re: Notice of issue in SMPP Driver
> >
> >
> > Is there a patch for this?  What is the status of this bug?
> > And the race
> > condition?
> > I've had cases of similar behaviour where the driver fails to send
> > messages out
> > and nothing else but a restart helps.
> >
> > I understood from the following messages that this is a
> > fundamental problem
> > with the smpp driver. How to fix this?
> >
> > Regards,
> > Indrek
> >
> >
> > Michael Mulcahy wrote:
> >
> > >Hi All,
> > >
> > >There is a bug in the current SMPP driver that stops the driver from
> > >accepting messages to be submitted to the SMSC.
> > >
> > >Scenario:
> > >SMPP SMSC configured as receiver and transmitter, transmitter and
> > >receiver connected and bound successfully.
> > >1) Receiver SMPP connection disconnects
> > >2) SMPP SMSC status changed to SMSCCONN_RECONNECTING
> > >3) Receiver SMPP connection reconnects to SMSC after reconnect delay
> > >   and sends bind_receiver pdu
> > >4) In handling of bind_receiver_resp the status is incorrectly set to
> > >   SMSCCONN_ACTIVE_RECV as the previous status was
> > SMSCCONN_RECONNECTING
> > >   (This does not take into account that the transmitter is still
> > >successfully
> > >   connected)
> > >5) Now the driver cannot receive any messages for submission to SMSC
> > >   as status is not SMSCCONN_ACTIVE.
> > >
> > >There also appears to be a potential race condition in the
> > >handling of the bind_transmitter_resp and the
> > bind_receiver_resp pdus,
> > >the status variable is modified in both places and is not protected.
> > >
> > >Regards,
> > >Michael Mulcahy.
> > >
> > >ANAM Wireless Internet Solutions
> > >http://www.anam.com mailto:[email protected]
> > >+353 1 284 7555
> > >Castle Yard, Saint Patrick's Road, Dalkey, County Dublin, Ireland
> > >
> > >
> > >
> > >