Re: [PATCH] make SMPP's PDU parsing more robust
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
Hi Alexander, Alexander Malysh schrieb: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > attached patch make parsing of SMPP optional parameters more robust (IMHO). > Patch include some cleanups , increasing MAX_SMPP_PDU_LEN (because > message_payload can be up to 64K octets) and add ability to dump optional > parameters. > > I have rewritten parsing of optional parameters. Please look in it and say > what is more robust (my implementation , based on original, or the original). > My implementation was tested with 3 different SMSC implementations. > > comments and votes please ... looks good to me, while untested yet. I'll try to hit some SMPP SMSCs we use and see if standard operations work well. BTW, which 3 SMSC vendors did you test against?! Stipe [email protected] ------------------------------------------------------------------- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [email protected] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are