Re: [PATCH] cimd2 validity period
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
Nicholas Rahn wrote: > > Attached is a patch implementing the validity period (relative) for > CIMD2 connections. It has been tested with one of our swiss CIMD2 > connections. patch commited to cvs. > The documentation for the "validity" parameter (sendsms interface) in > the User's Guide does not mention that this functionality might not be > implemented for certain SMSC types. We found that it wasn't implemented > for CIMD2 only after our clients told us it didn't work. I'd be willing > to write an explanation sentence or 2 for the "validity" parameter > (sendsms interface) of the User's Guide if someone can tell me what > other SMSCs it works/doesn't work for. yep, that would be great. > Question: In this patch, the "algorithm" to convert a time in minutes > into a integer according to the GSM 03.40 (section 9.2.3.12) spec was > copied from smsc_at2.c. Is there a place in kannel where a generic > function like this could be added rather than copying code? hmm, that's a good hint. We should have a "shared" file that incorporates the GSM specific routines?! Stipe [email protected] ------------------------------------------------------------------- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [email protected] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are