Re: [RFC] yesterday commits

I will fix this.

Aarno

On Friday, February 14, 2003, at 08:41 AM, Stipe Tolj wrote:

> Hi Aarno,
>
> can you comment on this part of your patch, please:
>
> Index: gateway/gwlib/socket.c
> diff -u gateway/gwlib/socket.c:1.53 gateway/gwlib/socket.c:1.54
> --- gateway/gwlib/socket.c:1.53 Wed Nov 13 10:22:56 2002
> +++ gateway/gwlib/socket.c      Thu Feb 13 10:35:48 2003
> @@ -510,7 +510,7 @@
>  }
>
>
> -static void setup_official_name(void)
> +static int  setup_official_name(void)
>  {
>      struct utsname u;
>      struct hostent h;
> @@ -519,14 +519,15 @@
>      if (uname(&u) == -1)
>          panic(0, "uname failed - can't happen, unless " GW_NAME " is
> buggy.");
>      if (gw_gethostbyname(&h, u.nodename) == -1) {
> -        error(0, "Can't find out official hostname for this host, "
> -              "using `%s' instead.", u.nodename);
> +        /*error(0, "Can't find out official hostname for this host, "
> +              "using `%s' instead.", u.nodename);*/
>          official_name = octstr_create(u.nodename);
>         official_ip = octstr_create("127.0.0.1");
> -    } else {
> -        official_name = octstr_create(h.h_name);
> -       official_ip = gw_netaddr_to_octstr(AF_INET, h.h_addr);
> -    }
> +        return 0;
> +    }
> +
> +    official_name = octstr_create(h.h_name);
> +    official_ip = gw_netaddr_to_octstr(AF_INET, h.h_addr);
>  }
>
>
> why is that change necessary?
>
> BTW, it throughs warnings on the automatic compilation test, as you
> may have noticed. See devel-report@ list.
>
> Stipe
>
> [email protected]
> -------------------------------------------------------------------
> Wapme Systems AG
>
> Vogelsanger Weg 80
> 40470 Düsseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [email protected]
> Internet: http://www.wapme-systems.de
> -------------------------------------------------------------------
> wapme.net - wherever you are
>