[RFC] config directive 'country-prefix' in wap-push-user group

Stipe Tolj <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Wapme Systems AG
Message-ID <[email protected]>
Hi Aarno,
Hi others,

AFAIS, the 'country-prefix' is simply prefixed to the given number in
case it's set for a wap-push-user group, see
gw/wap_push_ppg_pushuser.c:770:

    if (u->denied_prefix != NULL) {
        denied = octstr_split(u->denied_prefix, octstr_imm(";"));
        for (i = 0; i < list_len(denied); ++i) {
             listed_prefix = list_get(denied, i);
             if (u->country_prefix != NULL)
                 octstr_insert(listed_prefix, u->country_prefix, 0);
             if (compare_octstr_sequence(number, listed_prefix, 
                     0) == 0) {
      	         goto denied;
             }
        }
    }

hmm, shouldn't this be done via out 'unified-prefix' prefix
normalization routine?! Basically the functionality is similiar, but
there are two approaches.

I'd like to eliminate country-prefix and use either the global
unified-prefix from group core or allow a dedicated unified-prefix for
a wap-push-user group. (the same way we do it for smsc groups).

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.