Re: [PATCH] allow setting service-type for SMPP SMSC
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
David Holland wrote: > > Please find below a patch to allow an SMPP SMSC group to contain a > service-type definition. Previously Kannel would always send NULL, i.e. > "use default service-type". I've tested this patch and it works against > Xwireless/Mblox SMPP server. If no-one objects I'll commit it to CVS and > update the userguide. > > Many thanks to Nick Clarey for writing this when I realised what the > missing functionality was. seems clean to me from first glance, +1. One thing only: what's the default of the value if *no* config directive is given?! It looks you don't initialize the variable and hence you will pass garbage, or does cfg_get() return NULL in case the value is not given?! Stipe [email protected] ------------------------------------------------------------------- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [email protected] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are