[PATCH] Re: RE : SMPP 3.3 trouble

Hi,

please apply attached patch and try again...
For all: SMPP v3.4 spec allow sequence number in the range from 0x00000001 to 0x7FFFFFFF
And we send 0x0 , that is wrong and SMSC do right job!
I have sent similar patch for a while but .....


Am Freitag, 21. Februar 2003 13:29 schrieb Raphael Bellec:
> Thanks, I just applied it and I have the following log (see below).
>
> I have 2 questions:
> - Why is there 2 enquire link, is there one for the transmitter and one
> for the receiver?
> - The sequence number of the generic_nack seems to refer to the bind
> transmitter and bind_receiver. Is it the case? If it is, why does the
> SMSC wait for the enquire_link to send the generic_nack. If it is not
> the case, what could explain it? (SMSC trouble? ).
>
> Regards.
>
> 2003-02-21 11:28:18 [0] INFO: Kannel bearerbox II version 1.3.1 starting
> 2003-02-21 11:28:18 [0] INFO: MAIN: Start-up done, entering mainloop
> 2003-02-21 11:28:18 [7] DEBUG: sms_router: time to sleep
> 2003-02-21 11:28:18 [7] DEBUG: sms_router: list_len = 0
> 2003-02-21 11:28:18 [5] DEBUG: SMPP[opsmsc]: Sending PDU:
> 2003-02-21 11:28:18 [5] DEBUG: SMPP PDU 0x80f3b48 dump:
> 2003-02-21 11:28:18 [5] DEBUG:   type_name: bind_transmitter
> 2003-02-21 11:28:18 [5] DEBUG:   command_id: 2 = 0x00000002
> 2003-02-21 11:28:18 [5] DEBUG:   command_status: 0 = 0x00000000
> 2003-02-21 11:28:18 [5] DEBUG:   sequence_number: 0 = 0x00000000
> 2003-02-21 11:28:18 [5] DEBUG:   system_id: "***"
> 2003-02-21 11:28:18 [5] DEBUG:   password: "***"
> 2003-02-21 11:28:18 [5] DEBUG:   system_type: "VMA"
> 2003-02-21 11:28:18 [5] DEBUG:   interface_version: 51 = 0x00000033
> 2003-02-21 11:28:18 [5] DEBUG:   addr_ton: 0 = 0x00000000
> 2003-02-21 11:28:18 [5] DEBUG:   addr_npi: 0 = 0x00000000
> 2003-02-21 11:28:18 [5] DEBUG:   address_range: ""
> 2003-02-21 11:28:18 [5] DEBUG: SMPP PDU dump ends.
> 2003-02-21 11:28:18 [6] DEBUG: SMPP[opsmsc]: Sending PDU:
> 2003-02-21 11:28:18 [6] DEBUG: SMPP PDU 0x80f3c78 dump:
> 2003-02-21 11:28:18 [6] DEBUG:   type_name: bind_receiver
> 2003-02-21 11:28:18 [6] DEBUG:   command_id: 1 = 0x00000001
> 2003-02-21 11:28:18 [6] DEBUG:   command_status: 0 = 0x00000000
> 2003-02-21 11:28:18 [6] DEBUG:   sequence_number: 1 = 0x00000001
> 2003-02-21 11:28:18 [6] DEBUG:   system_id: "***"
> 2003-02-21 11:28:18 [6] DEBUG:   password: "***"
> 2003-02-21 11:28:18 [6] DEBUG:   system_type: "VMA"
> 2003-02-21 11:28:18 [6] DEBUG:   interface_version: 51 = 0x00000033
> 2003-02-21 11:28:18 [6] DEBUG:   addr_ton: 0 = 0x00000000
> 2003-02-21 11:28:18 [6] DEBUG:   addr_npi: 0 = 0x00000000
> 2003-02-21 11:28:18 [6] DEBUG:   address_range: ""
> 2003-02-21 11:28:18 [6] DEBUG: SMPP PDU dump ends.
>
> 2003-02-21 11:28:48 [5] DEBUG: SMPP[opsmsc]: Sending enquire link:
> 2003-02-21 11:28:48 [5] DEBUG: SMPP PDU 0x80f3c78 dump:
> 2003-02-21 11:28:48 [5] DEBUG:   type_name: enquire_link
> 2003-02-21 11:28:48 [5] DEBUG:   command_id: 21 = 0x00000015
> 2003-02-21 11:28:48 [5] DEBUG:   command_status: 0 = 0x00000000
> 2003-02-21 11:28:48 [5] DEBUG:   sequence_number: 2 = 0x00000002
> 2003-02-21 11:28:48 [5] DEBUG: SMPP PDU dump ends.
> 2003-02-21 11:28:48 [6] DEBUG: SMPP[opsmsc]: Sending enquire link:
> 2003-02-21 11:28:48 [6] DEBUG: SMPP PDU 0x80f3c78 dump:
> 2003-02-21 11:28:48 [6] DEBUG:   type_name: enquire_link
> 2003-02-21 11:28:48 [6] DEBUG:   command_id: 21 = 0x00000015
> 2003-02-21 11:28:48 [6] DEBUG:   command_status: 0 = 0x00000000
> 2003-02-21 11:28:48 [6] DEBUG:   sequence_number: 3 = 0x00000003
> 2003-02-21 11:28:48 [6] DEBUG: SMPP PDU dump ends.
> 2003-02-21 11:28:48 [5] DEBUG: SMPP[opsmsc]: Got PDU:
> 2003-02-21 11:28:48 [5] DEBUG: SMPP PDU 0x80f3cc0 dump:
> 2003-02-21 11:28:48 [5] DEBUG:   type_name: generic_nack
> 2003-02-21 11:28:48 [5] DEBUG:   command_id: 2147483648 = 0x80000000
> 2003-02-21 11:28:48 [5] DEBUG:   command_status: 4 = 0x00000004
> 2003-02-21 11:28:48 [5] DEBUG:   sequence_number: 0 = 0x00000000
> 2003-02-21 11:28:48 [5] DEBUG: SMPP PDU dump ends.
> 2003-02-21 11:28:48 [5] WARNING: SMPP[opsmsc]: SMSC sent generic_nack
> with wrong sequence number 0x00000000
> 2003-02-21 11:28:48 [5] ERROR: SMPP[opsmsc]: I/O error or other error.
> Re-connecting.
> 2003-02-21 11:28:49 [6] DEBUG: SMPP[opsmsc]: Got PDU:
> 2003-02-21 11:28:49 [6] DEBUG: SMPP PDU 0x80f3c50 dump:
> 2003-02-21 11:28:49 [6] DEBUG:   type_name: generic_nack
> 2003-02-21 11:28:49 [6] DEBUG:   command_id: 2147483648 = 0x80000000
> 2003-02-21 11:28:49 [6] DEBUG:   command_status: 4 = 0x00000004
> 2003-02-21 11:28:49 [6] DEBUG:   sequence_number: 1 = 0x00000001
> 2003-02-21 11:28:49 [6] DEBUG: SMPP PDU dump ends.
> 2003-02-21 11:28:49 [6] WARNING: SMPP[opsmsc]: SMSC sent generic_nack
> with wrong sequence number 0x00000001
> 2003-02-21 11:28:49 [6] ERROR: SMPP[opsmsc]: I/O error or other error.
> Re-connecting.
> 2003-02-21 11:28:49 [5] DEBUG: SMPP[opsmsc]: Sending PDU:
> 2003-02-21 11:28:49 [5] DEBUG: SMPP PDU 0x80f3b48 dump:
> 2003-02-21 11:28:49 [5] DEBUG:   type_name: bind_transmitter

-- 
Best regards / Mit besten Grüßen aus Köln

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Ehrenstraße 2
50672 Köln

Fon: +49 (0221) 277 49 240
Fax: +49 (0221) 277 49 109

email: [email protected]
web: www.centrium.de
msn: [email protected]
icq: 98063111

Index: gw/smsc/smsc_smpp.c
===================================================================
RCS file: /home/cvs/gateway/gw/smsc/smsc_smpp.c,v
retrieving revision 1.24
diff -a -u -r1.24 smsc_smpp.c
--- gw/smsc/smsc_smpp.c	18 Feb 2003 14:40:38 -0000	1.24
+++ gw/smsc/smsc_smpp.c	21 Feb 2003 13:02:25 -0000
@@ -133,6 +133,7 @@
     list_add_producer(smpp->msgs_to_send); 
     smpp->received_msgs = list_create(); 
     smpp->message_id_counter = counter_create(); 
+    counter_increase(smpp->message_id_counter);
     smpp->host = octstr_duplicate(host); 
     smpp->system_type = octstr_duplicate(system_type); 
     smpp->username = octstr_duplicate(username);