Re: bug in smsc_smpp.c login failure

hi

yeah.. great +1

nisan
At 11:27 AM 2/27/03 +0100, Alexander  Malysh wrote:
>Content-Type: text/plain;
>   charset="iso-8859-1"
>Content-Disposition: inline
>X-MIME-Autoconverted: from 8bit to quoted-printable by mail-in-01.piro.net 
>id LAA28081
>
>Hi,
>
>what about attached patch ?
>
>Am Donnerstag, 27. Februar 2003 10:30 schrieb Stipe Tolj:
> > Alan McNatty wrote:
> > > On Thu, 2003-02-27 at 18:54, Nisan Bloch wrote:
> > > > Hi
> > > >
> > > > At 03:46 PM 2/27/03 +1300, Alan McNatty wrote:
> > > > >Hello,
> > > > >
> > > > >found that if I type in the smpp password incorrectly kannel loops
> > > > >forever trying to reconnect. ie:
> > > >
> > > > -1 from me
> > > > In the current form this path will not allow any retries for any sort
> > > > of bind error. eg what happens if there is a temporary connectivity
> > > > issue, or the SMPP server is down for a short while/
> > >
> > > What I'm trying highlight is that there is a gap in logic ..
> > > Currently regardless of the type of error we continually retry to bind.
> > > If we specifically receive an error indicating the password is invalid
> > > the SMSC is obviously up but we may as well kill the thread.
> >
> > yep, that's true in some sense. Trying to reconnect forever while we
> > get the error information from the SMSC that we can't login with that
> > credentials *could* be considered as login abuse :)
> >
> > At least I would consider this if our SMPP clients would hammer our
> > SMPP server with invalid credentials.
> >
> > Stipe
> >
> > [email protected]
> > -------------------------------------------------------------------
> > Wapme Systems AG
> >
> > Vogelsanger Weg 80
> > 40470 Düsseldorf
> >
> > Tel: +49-211-74845-0
> > Fax: +49-211-74845-299
> >
> > E-Mail: [email protected]
> > Internet: http://www.wapme-systems.de
> > -------------------------------------------------------------------
> > wapme.net - wherever you are
>
>--
>Best regards / Mit besten Grüßen aus Köln
>
>Dipl.-Ing.
>Alexander Malysh
>___________________________________________
>
>Centrium GmbH
>Ehrenstraße 2
>50672 Köln
>
>Fon: +49 (0221) 277 49 240
>Fax: +49 (0221) 277 49 109
>
>email: [email protected]
>web: www.centrium.de
>msn: [email protected]
>icq: 98063111
>