Re: ppg push - incorrect pap result?

> I'm using Openwave's WAP push library to push messages to Kannel's ppg,
> however, it doesn't work too well. One thing is that the library tells
> me the response from the PPG is wrong. I am looking at the XML response
> generated by Kannel (cvs version) which looks like this:
> 
> <?xml version="1.0"?>
> <!DOCTYPE pap PUBLIC "-//WAPFORUM//DTD PAP 1.0//EN"
> "http://www.wapforum.org/DTD/pap_1.0.dtd">
> <pap>
>     <push-response push-id="1" sender-name="bas-laptop.localdomain;
> WAP/1.3 (Kannel/cvs-20030307)" reply-time="2003-03-19T14:53:11Z"
> sender-address="/wappush">
>     </push-response>
>     <response-result code ="1001" desc="The request has been accepted for
> processing"></response-result>
> </pap>
> 
> I compared this to the output of another PPG and looked at the PAP spec
> (WAP-247-PAP-20010429-a.pdf). As far as I can tell, it looks like the
> document returned by Kannel is not correct: the 'response-result'
> element is a child of 'pap', which is not ok according to the spec. It
> should be a child of the 'push-response' element. That would look like
> this:
> 
> <?xml version="1.0"?>
> <!DOCTYPE pap PUBLIC "-//WAPFORUM//DTD PAP 1.0//EN"
> "http://www.wapforum.org/DTD/pap_1.0.dtd">
> <pap>
>     <push-response push-id="1" sender-name="bas-laptop.localdomain;
> WAP/1.3 (Kannel/cvs-20030307)" reply-time="2003-03-19T14:53:11Z"
> sender-address="/wappush">
>        <response-result code ="1001" desc="The request has been accepted
> for processing"></response-result>
>     </push-response>
> </pap>
> 
> I just modified gw/wap_push_ppg.c to format the XML like this and now it
> works with the Openwave push library.
> 
> Can anyone "in the know" comment on this?
> 
> Below find the patch,

thanks a lot. +1 as Aarno stated. commited to cvs.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are