Re: [PATCH]ppg push - crashing bug trusted-pi/no user

Stipe Tolj <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Wapme Systems AG
Message-ID <[email protected]>
Bas,

why is the 

  if (username == NULL || (octstr_str_compare(username,"") == 0)) {

  } else {

  }

necessary?!

AFAIS, wap_push_ppg_pushuser_smsc_id_get() will return NULL in case no
user is found. Ok at least it may be a performance thing not to look
into the dict hash if anyway no username is given. 

Is it because of that? Or is it really functionally necessary? I don't
see why.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.