Re: [PATCH]ppg push - crashing bug trusted-pi/no user

Stipe Tolj <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Wapme Systems AG
Message-ID <[email protected]>
> In theory, only the patch to wap_push_ppg_pushuser.c is needed to
> prevent the crash. However, why bother to have pap_request_thread call
> wap_push_ppg_pushuser_smsc_id_get when you already know there is no
> username to make wap_push_ppg_pushuser_smsc_id_get do something usefull?
> Also, it allows to differentiate between the 2 situations if needed
> (e.g. logging).

yep, the fix inside wap_push_ppg_pushuser_smsc_id_get() is *definetly*
needed. Ok, with performance in mind we'll also add the if clause.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.