[RFC] autodetect smpp source_addr_ton should not remove + (plus)

At least in the cases I have tested, if you remove the plus '+' from the
front of an originator number / source address, the originator mobile
number turns up on the end user's mobile without a '+' (makes sense) and
the user cannot reply to it correctly -- Nokia 6110, 7110.

The cases that don't work for us are *local* numbers that we prefix to +61
(Australia). Our SMSC doesn't permit NATIONAL number submission in TON.

I haven't tried an overseas originator mobile number.

(Strangely, the SMSC's special TPOA assigned to us does work without the +
prefix.)

Comments?



Index: smsc_smpp.c
===================================================================
RCS file: /home/cvs/gateway/gw/smsc/smsc_smpp.c,v
retrieving revision 1.31
diff -u -b -r1.31 smsc_smpp.c
--- smsc_smpp.c 19 Mar 2003 17:43:11 -0000      1.31
+++ smsc_smpp.c 25 Mar 2003 16:00:23 -0000
@@ -366,6 +366,8 @@
                 pdu->u.submit_sm.source_addr_npi = GSM_ADDR_NPI_UNKNOWN;    /* short code */
             } else {
                /* numeric sender address with + in front -> international (remove the +) */
+
+                /* should this be configurable? */
                octstr_delete(pdu->u.submit_sm.source_addr, 0, 1);
                pdu->u.submit_sm.source_addr_ton = GSM_ADDR_TON_INTERNATIONAL;
            }


-- 
Benjamin Lee

Level 2 71-75 City Rd, South Melbourne, VIC 3006 Australia
Phone +61 3 8699 1333  Mobile +61 414 717 573  Fax +61 3 8699 1388