RE: [PATCH] small fix to previous patch

Clean patch, my vote is +1 for this.

It does minimal changes, and does not modify the default behaviour if the
new directive is not used.

Angel Fradejas
Mediafusion Espana, S.A.
[email protected]
www.mediafusion.es
Tel. +34 91 252 32 00
Fax +34 91 572 27 08


-----Mensaje original-----
De: [email protected] [mailto:[email protected]]En nombre de
Dziugas Baltrunas
Enviado el: miercoles 2 de abril de 2003 10:42
Para: [email protected]
Asunto: [PATCH] small fix to previous patch


Hi list,

after some test I found small logical mistake in my previous patch.
it was with checking:

else if( !pdata->no_dlr && (msg->sms.dlr_mask & 0x03) )
	warning(0, "CIMD2[%s]: dlr request make no sense while no-dlr set to
false",
		octstr_get_cstr(conn->id));

and there should be

else if( pdata->no_dlr && (msg->sms.dlr_mask & 0x03) )
        warning(0, "CIMD2[%s]: dlr request make no sense while no-dlr set to
true",
                octstr_get_cstr(conn->id));

i.e. if no-dlr is set to true and dlrmask is also set, it should produce
the warning.

this is fixed in the attached diff. sorry.

regards,
Dziugas Baltrunas