Re: patch for empy message and UDH > 140
Andreas Fink <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
On Montag, Mai 5, 2003, at 05:47 Uhr, Oleg Titov wrote: > hi, please check out this patch used to solve the "empty" message and > kannel smsbox crash on UDH > 140. > > First part of the patch checks for the presence of the text message > and UDH header, now it should be possible to send pure UDH messages > (without "<Empty ..." string as text). > > Second part, checks for UDH length, if it more than 140 - the reject > message will be sent to http interface. > > -- > Best regards, > Oleg<smsbox.patch> I think there was some other place in the code where an empty text message is discarded or similar. At least "should we allow empty text or not" was a discussion a while back. Proper testing with every SMSC type would be advisable. For the UDH, what happens if UDH is 139 and text is lets say 20 chars? The text would be split into two SMS but there's not enough space left to add the segmentation header to the UDH. Have you checked that case? Andreas Fink Global Networks Switzerland AG ------------------------------------------------------------------ Tel: +41-61-6666333 Fax: +41-61-6666334 Mobile: +41-79-2457333 Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland Web: http://www.global-networks.ch/ [email protected] ------------------------------------------------------------------