Re[2]: patch for empy message and UDH > 140

Hello Andreas,

Monday, May 05, 2003, 6:59:15 PM, you wrote:


AF> On Montag, Mai 5, 2003, at 05:47  Uhr, Oleg Titov wrote:

>> hi, please check out this patch used to solve the "empty" message and
>> kannel smsbox crash on UDH > 140.
>>
>> First part of the patch checks for the presence of the text message
>> and UDH header, now it should be possible to send pure UDH messages
>> (without "<Empty ..." string as text).
>>
>> Second part, checks for UDH length, if it more than 140 - the reject
>> message will be sent to http interface.
>>
>> -- 
>> Best regards,
>>  Oleg<smsbox.patch>

AF> I think there was some other place in the code where an empty text 
AF> message is discarded or similar.
AF> At least "should we allow empty text or not" was a discussion a while 
AF> back. Proper testing with every SMSC type would be advisable.

AF> For the UDH, what happens if UDH is 139 and text is lets say 20 chars?

AF> The text would  be split into two SMS but there's not enough space left 
AF> to add the segmentation header to the UDH.
AF> Have you checked that case?

AF> Andreas Fink
AF> Global Networks Switzerland AG

AF> ------------------------------------------------------------------
AF> Tel: +41-61-6666333  Fax: +41-61-6666334   Mobile: +41-79-2457333
AF> Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
AF> Web: http://www.global-networks.ch/      [email protected]
AF> ------------------------------------------------------------------

Patching that way it only gives check if udh len > 140, but setting
UDH = 139 + TEXT = 3
must give error :(.

Need check summary of Data Len after packing all Data.

If it's text encode it to 140
and binary encode and check.

Thinking that it's the best way to make this, simply and beauty :)


---------------------------------------------------------
Jury Cherepanov
System Developer (Technical Director) , HIGH TECHNOLOGIES
Turaidas 2a, Riga, Latvia
Phone +371-9633398
mailto:[email protected]