Re: Re[2]: patch for empy message and UDH > 140

On Montag, Mai 5, 2003, at 06:12  Uhr, Oleg Titov wrote:

> Monday, May 5, 2003, 10:59:15 AM, you wrote:
> AF> On Montag, Mai 5, 2003, at 05:47  Uhr, Oleg Titov wrote:
>>> hi, please check out this patch used to solve the "empty" message and
>>> kannel smsbox crash on UDH > 140.
>>>
>>> First part of the patch checks for the presence of the text message
>>> and UDH header, now it should be possible to send pure UDH messages
>>> (without "<Empty ..." string as text).
>>>
>>> Second part, checks for UDH length, if it more than 140 - the reject
>>> message will be sent to http interface.
>>>
>>> -- 
>>> Best regards,
>>>  Oleg<smsbox.patch>
>
> AF> I think there was some other place in the code where an empty text
> AF> message is discarded or similar.
> AF> At least "should we allow empty text or not" was a discussion a 
> while
> AF> back. Proper testing with every SMSC type would be advisable.
> Sorry, I am new on this list and I missed that discussion. Let me check
> in archives. I was looking for solution to send EMS melodies without
> any text message attached.
>
> AF> For the UDH, what happens if UDH is 139 and text is lets say 20 
> chars?
> AF> The text would  be split into two SMS but there's not enough space 
> left
> AF> to add the segmentation header to the UDH.
> AF> Have you checked that case?
> That was out of my scope. I deal with a security hole for smsbox. If 
> you send
> UDH grater than 140 octets than smsbox dies.

I'm not saying the patch is genrally wrong at all.
I'm just giving a hint that it might still die in this case but at some 
other place.
I agree that SMSBox should be bullet proof, whatever you pass to it.

> In general, I feel that's responsibility of sender to prepare well
> formed UDH which takes into account split details.

We'll better check for such user errors to avoid crashes in later 
stages.

Andreas Fink
Global Networks Switzerland AG

------------------------------------------------------------------
Tel: +41-61-6666333  Fax: +41-61-6666334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/      [email protected]
------------------------------------------------------------------