Re: patch for empy message and UDH > 140
Andreas Fink <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
On Dienstag, Mai 6, 2003, at 07:52 Uhr, Nisan Bloch wrote: > At 11:53 AM 5/6/03 +0200, Stipe Tolj wrote: >> Andreas Fink wrote: >> >> > I agree that SMSBox should be bullet proof, whatever you pass to it. >> >> agreed, all smsbox (or other boxes that connect to bearerbox and >> interact with user-scope) should be bullet proof. >> >> So please excessive testing mode on. ;) > > > this is a problem we run into as well.. its a tricky one, as we dont > want Kannel to have to know about the various forms of UDH, esp. with > EMS et al in mind. > Then there is the issue that some EMS messages are all UDH and no > msgdata. > If one completely removes the checking of the length of the UDH > against the first byte then there is the problem of bufferoveruns and > assumptions about lengths of udh and msgdata in the smsc modules. > > In order for Kannel to split all messages succesfully it will have to > know about EMS at least. No. This is NOT true. EMS has nothing to do with it UDH of over 140 bytes can definitively not be split. You can only split text/data part which creates an additional item on the UDH. > We almost need an extra sendsms param to tell Kannel not to attempt to > split a particular message. Kannel NEVER splits unless it really has to do so. If the message is oversize, kannel has 3 options: drop, truncate or split. Currently it uses split if you allow concatenated messages in the config file otherwise it truncates. > As far as the patch is concerned we are running with something very > similar, but it is far from perfect. > > Essentially I reckon that Kannel should accept any udh/msgdata > combination, along with a flag to disable concat/split on a per msg > basis. Whether udh or msgdata are required and their relative lengths > is really something the smsc modules should deal with. I dont see why you should allow/disallow splitting on a per message basis. you can create two users for this if you need it today. Andreas Fink Global Networks Switzerland AG ------------------------------------------------------------------ Tel: +41-61-6666333 Fax: +41-61-6666334 Mobile: +41-79-2457333 Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland Web: http://www.global-networks.ch/ [email protected] ------------------------------------------------------------------