Re: [RFC] releasing 1.3.2 development

Heh, it's not a SMPP problem :) It a problem with inconsistency in DLR 
handling itself. We should not change smpp for this , we should just fix dlr 
handling (imho). 

Please vote which handling storage do right thing:
	1) Internal (reversed source and destination address in dlr)
	2) Mysql (not reversed)

My +1 going for Mysql.

Comments please...

Am Mittwoch, 7. Mai 2003 13:33 schrieb David Tully:
> > First of all, I can't find this patch or I have found one patch but it
> > has nothing todo with dlr's...
>
> Sorry - wrong subject:
> It was posted in : 'Re: INFO: NOTE: sender and receiver same number
> <41313131313>, ignoring!', posted by Nisan on the 14/04.
>
> > > Mysql DLR on SMPP won't work without it and it's still broken in CVS
>
> (along
>
> > > with 1.2.1 and 1.3.1).
> >
> > Mysql dlr (and all other too) do not compare source/destination address ,
>
> so
>
> > it is not a problem/bug to find dlr entry in db.
>
> That is true, but when bearerbox gives the URL to smsbox, smsbox gives an
> error of source and destination the same.
> The problem is that the source address in the destination address are
> reversed. %p and %P fields are switched.
>
> Here's the change from Nisan's email:
>
>
> CVS in gw/smsc/smsc_smpp.c line 918
> does this
>                     dlrmsg = dlr_find(octstr_get_cstr(smpp->conn->id),
>                                       octstr_get_cstr(tmp), /* smsc message
> id */
>
> octstr_get_cstr(pdu->u.deliver_sm.destination_addr), /* destination */
>                                       dlrstat);
>
> IT Should be
>
>                     dlrmsg = dlr_find(octstr_get_cstr(smpp->conn->id),
>                                       octstr_get_cstr(tmp), /* smsc message
> id */
>
> octstr_get_cstr(pdu->u.deliver_sm.source_addr), /* destination */
>                                       dlrstat);
>
>
>
> Regards,
>
> David.
>
> > Regards,
> >
> > Dave.
> >
> > ----- Original Message -----
> > From: "Stipe Tolj" <[email protected]>
> > To: <[email protected]>
> > Sent: Wednesday, May 07, 2003 11:33 AM
> > Subject: [notspam] [RFC] releasing 1.3.2 development
> >
> > > Hi list,
> > >
> > > Aarno and me are findling arround the Siemens S55 problem with WSP
> > > encoding-version. As this is yet not fully solved, I'd like to release
> > > 1.3.2 anyway now and update as soon as we implemented this in a clean
> > > manner.
> > >
> > > Any objections against tagging the cvs tree for 1.3.2?
> > >
> > > Stipe
> > >
> > > [email protected]
> > > -------------------------------------------------------------------
> > > Wapme Systems AG
> > >
> > > Vogelsanger Weg 80
> > > 40470 Düsseldorf
> > >
> > > Tel: +49-211-74845-0
> > > Fax: +49-211-74845-299
> > >
> > > E-Mail: [email protected]
> > > Internet: http://www.wapme-systems.de
> > > -------------------------------------------------------------------
> > > wapme.net - wherever you are
>
> --
> Best regards / Mit besten Grüßen aus Köln
>
> Dipl.-Ing.
> Alexander Malysh
> ___________________________________________
>
> Centrium GmbH
> Ehrenstraße 2
> 50672 Köln
>
> Fon: +49 (0221) 277 49 240
> Fax: +49 (0221) 277 49 109
>
> email: [email protected]
> web: www.centrium.de
> msn: [email protected]
> icq: 98063111

-- 
Best regards / Mit besten Grüßen aus Köln

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Ehrenstraße 2
50672 Köln

Fon: +49 (0221) 277 49 240
Fax: +49 (0221) 277 49 109

email: [email protected]
web: www.centrium.de
msn: [email protected]
icq: 98063111