Re: [RFC] [Fwd: small patches]

At 05:00 AM 5/27/03 +0200, Stipe Tolj wrote:
>Hi list,
>
>anyone from the developers having votes for this patch or single
>components?!
>
>I'm +0. Obviously there is nothing wrong about it, but I don't see the
>necessarity.


I would go with a +1. There is nothing wrong with the patches. These two 
look quite reasonable
gwlib/gwthread-pthread.c
gw/bb_boxc.c
and would only help make Kannel src more defensive and stable.

Nisan


>Stipe
>
>[email protected]
>-------------------------------------------------------------------
>Wapme Systems AG
>
>Vogelsanger Weg 80
>40470 Düsseldorf
>
>Tel: +49-211-74845-0
>Fax: +49-211-74845-299
>
>E-Mail: [email protected]
>Internet: http://www.wapme-systems.de
>-------------------------------------------------------------------
>wapme.net - wherever you areReturn-path: <[email protected]>
>Envelope-to: [email protected]
>Delivery-date: Wed, 07 May 2003 10:04:23 -0400
>Received: from [62.96.19.131] (helo=wapme-mail01.wapme-systems.de)
>         by protheus.dev.wapme.net with esmtp (Exim 4.04)
>         id HEISF8-0001EO-00
>         for [email protected]; Wed, 07 May 2003 10:04:20 -0400
>Thread-Index: AcMUoVnSy08i9cZkRYusOKiGrbXNTw==
>Received: from ftp.wapme.net ([62.96.19.135]) by 
>wapme-mail01.wapme-systems.de with Microsoft SMTPSVC(5.0.2195.4905); Wed, 
>7 May 2003 16:02:44 +0200
>Received: (from uucp@localhost) by ftp.wapme.net (8.11.6/8.11.6) id 
>h47E1hB19922; Wed, 7 May 2003 16:01:43 +0200
>Received: from UNKNOWN(62.254.217.163), claiming to be "geodude.3glab.org" 
>via SMTP by mail, id smtpdqtll6T; Wed May  7 16:01:33 2003
>Content-Transfer-Encoding: 7bit
>Received: from localhost.localdomain ([127.0.0.1] helo=geodude.3glab.org) 
>by geodude.3glab.org with esmtp (Exim 3.22 #1) id 19DPTi-0001VW-00; Wed, 
>07 May 2003 15:01:02 +0100
>Received: from [213.30.75.8] (helo=odie.graycell.biz) by geodude.3glab.org 
>with esmtp (Exim 3.22 #1) id 19DPTZ-0001V1-00 for [email protected]; Wed, 
>07 May 2003 15:00:53 +0100
>Received: from taz ([10.1.1.11]) by odie.graycell.biz with Microsoft 
>SMTPSVC(5.0.2195.5329); Wed, 7 May 2003 15:00:22 +0100
>content-class: urn:content-classes:message
>Priority: normal
>From: "Nuno Ferreira" <[email protected]>
>To: "Kannel Devel" <[email protected]>
>Subject: small patches
>Organization: Graycell
>Message-ID: <[email protected]>
>MIME-Version: 1.0
>Content-Type: multipart/mixed;
>         boundary="----=_NextPart_000_0057_01C314A9.621F68C0"
>X-Priority: 3 (Normal)
>X-MSMail-Priority: Normal
>X-Mailer: Microsoft Outlook, Build 10.0.4510
>X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200
>Importance: Normal
>X-OriginalArrivalTime: 07 May 2003 14:00:22.0500 (UTC) 
>FILETIME=[005EAA40:01C314A1]
>Sender: <[email protected]>
>Errors-To: [email protected]
>X-BeenThere: [email protected]
>X-Mailman-Version: 2.0.13
>Precedence: bulk
>List-Help: <mailto:[email protected]?subject=help>
>List-Post: <mailto:[email protected]>
>List-Subscribe: 
><http://www.kannel.org/mailman/listinfo/devel>,<mailto:[email protected]?subject=subscribe>
>List-Id: Development mailing list <devel.kannel.org>
>List-Unsubscribe: 
><http://www.kannel.org/mailman/listinfo/devel>,<mailto:[email protected]?subject=unsubscribe>
>List-Archive: <http://www.kannel.org/mailman/private/devel/>
>X-Original-Date: Wed, 7 May 2003 15:00:22 +0100
>Date: Wed, 7 May 2003 15:00:22 +0100
>X-Mozilla-Status2: 00000000
>
>Hi,
>while trying to understand kannel sources and doing some tests I
>found some small problems, here is the patch.
>Note that I didn't see any real problem happening, those are just
>potential errors.
>Also, I had a situation where smsbox wouldn't die, after I tried killing
>it just entered an infinite loop doing pool (verified with strace). Is
>it a known problem?
>
>Anyway, here's the ChangeLog
>2003-05-07  Nuno Ferreira  <[email protected]>
>     * gwlib/gwthread-pthread.c (gwthread_pollfd): initialize revents to 0,
>       otherwise an initialized value can be read when the wait times out.
>     * gw/bb_boxc.c: add forward declaration of route_incoming_sms to avoid
>       compiler warning
>       (boxc_sender): unlock boxc_id_mutex so that the creating thread can
>       safely destroy the mutex
>     * gw/smsc/smsc_emi2.c (smsc_emi2_create): initialize check_time
>
>Any comments?
>
>--
>Nuno Ferreira
>graycell - Consultoria e Sistemas de Informação Lda.