[PATCH] smsc_cimd2.c (was: Segmentation fault in latest CVS)

Hi again,

This patch should solve these cimd2 problems reported earlier by Illimar 
Reinbusch. The octstr ts in cimd2_submit_msg() was never initialized if the 
socket had been closed, octstr_destroy() caused a segmentation fault.

NOTE: This patch also contains the not yet committed misc. fixes for 
smsc_cimd2.c I submitted earlier. I belive at least Angel voted in favour 
of that patch (thanks), Stipe?
 
-- 
Per Skaglund
Dialtone Oy
Tekniikantie 14, FIN-02150 Espoo, Finland
Tel. +358941743434, Mobile +358405198377


-----Original Message-----
From:	Illimar Reinbusch [SMTP:[email protected]]
Sent:	Monday, May 19, 2003 11:18 AM
To:	Illimar Reinbusch; '[email protected]'
Subject:	RE: Segmentation fault in latest CVS

Hi

Error confirmed. Every time CIMD2 tries to send message to connection
what is allready dead, creates segmentation fault.

Illimar 

> Problem seems to be then Kannel tries to send message but then
> finds out that CIMD2 SMSC is not responding...
> 
> 2003-05-15 12:17:06 [12] DEBUG: CIMD2[xxxx]: sending message
> 2003-05-15 12:17:06 [12] DEBUG: CIMD2[xxxx]: sending <.03:000
> 021:xxxxxxxxx 056:0   055:0   032:06050415810000      03 ....
> 
> and then...
> 
> 2003-05-15 12:17:13 [13] WARNING: CIMD2[xxxx]: SMSC is not responding
> 2003-05-15 12:17:13 [13] WARNING: CIMD2[xxxx]: SMSC not alive.
> 2003-05-15 12:17:16 [12] WARNING: CIMD2[xxxx]: SMSC is not responding
> 2003-05-15 12:17:16 [0] INFO: Connection closed by the bearerbox
> 2003-05-15 12:17:16 [0] INFO: Received (and handled?) 100 
> requests in 61071
> seconds (0.00 per second)
> 2003-05-15 12:17:16 [0] INFO: Kannel smsbox terminating.
> 2003-05-15 12:17:16 [7] DEBUG: Thread 7 
> (gw/heartbeat.c:heartbeat_thread)
> terminates.
> 2003-05-15 12:17:16 [0] DEBUG: Waiting for 2 
> (gwlib/http.c:server_thread) to
> terminate
> 2003-05-15 12:17:16 [3] DEBUG: HTTP: No clients with 
> requests, quitting.
> 2003-05-15 12:17:16 [3] DEBUG: Thread 3 (gw/smsbox.c:sendsms_thread)
> terminates.
> /var/kannel/runkannel: line 36:  5266 Segmentation fault
> 
> Illimar
> 

begin 600 smsc_cimd2.diff
M26YD97@Z(&=A=&5W87DO9W<O<VUS8R]S;7-C7V-I;60R+F,*/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/0I20U,@9FEL93H@+VAO;64O8W9S+V=A=&5W87DO9W<O
M<VUS8R]S;7-C7V-I;60R+F,L=@IR971R:65V:6YG(')E=FES:6]N(#$N,3(*
M9&EF9B M=2 M<C$N,3(@<VUS8U]C:6UD,BYC"BTM+2!G871E=V%Y+V=W+W-M
M<V,O<VUS8U]C:6UD,BYC"3(W($UA>2 R,# S(# S.C,V.C4Y("TP,# P"3$N
M,3(**RLK(&=A=&5W87DO9W<O<VUS8R]S;7-C7V-I;60R+F,),B!*=6X@,C P
M,R P.3HU-#HS-2 M,# P, I 0" M-CDL-R K-CDL-R! 0 H@"B *("\J($UI
M8W)O<V5C;VYD<R!B969O<F4@9VEV:6YG('5P(&]N(&$@<F5Q=65S=" J+PHM
M(V1E9FEN92!215-03TY315]424U%3U54("@Q," J(#$P,# P,# I"BLC9&5F
M:6YE(%)%4U!/3E-%7U1)345/550@*#8P("H@,3 P,# P,"D*( H@+RH@5&5X
M='5A;"!N86UE<R!F;W(@=&AE(&]P97)A=&EO;B!C;V1E<R!D969I;F5D(&)Y
M('1H92!#24U$(#(@<W!E8RX@*B\*("\J($EF('EO=2!M86ME(&-H86YG97,@
M:&5R92P@86QS;R!C:&%N9V4@=&AE(&]P97)A=&EO;B!T86)L92X@*B\*0$ @
M+3$T,S8L-B K,30S-BPY($! "B!S=&%T:6,@=F]I9"!P86-K971?<V5T7W-E
M;F1?<V5Q=65N8V4H<W1R=6-T('!A8VME=" J<&%C:V5T+"!0<FEV1&%T82 J
M<&1A=&$I"B!["B @(" @9W=?87-S97)T*'!D871A("$]($Y53$PI.PHK(" @
M("\J($Q/1TE.('!A8VME=',@86QW87ES(&AA=F4@<V5Q=65N8V4@;G5M8F5R
M(# P,2 J+PHK(" @(&EF("AP86-K970M/F]P97)A=&EO;B ]/2!,3T=)3BD*
M*R @(" @(" @<&1A=&$M/G-E;F1?<V5Q(#T@,3L*(" @(" O*B!396YD('-E
M<75E;F-E(&YU;6)E<G,@87)E(&%L=V%Y<R!O9&0L(')E8V5I=FEN9R!A<F4@
M86QW87ES(&5V96X@*B\*(" @("!G=U]A<W-E<G0H<&1A=&$M/G-E;F1?<V5Q
M("4@,B ]/2 Q*3L*( I 0" M,34S-2PW("LQ-3,X+#<@0$ *(" @("!T97AT
M(#T@<&%C:V5T7V=E=%]S;7-?<&%R;2AR97%U97-T+"!07U5315)?1$%402D[
M"B @(" @:68@*'1E>'0@(3T@3E5,3"D@>PH@(" @(" @("!C;VYV97)T7V-I
M;60R7W1O7V=S;2AT97AT+&-O;FXI.PHM(" @(" @(" O*F-H87)S970@/2!C
M:&%R<V5T7V=S;3L@(%1H:7,@;W9E<G)I9&5S('=H870@=V4@9V]T(&9R;VT@
M=&AE($1#4R J+PHK(" @(" @("!C:&%R<V5T7V=S;5]T;U]L871I;C$H=&5X
M="D["B @(" @?2!E;'-E('L*(" @(" @(" @+RH*(" @(" @(" @("H@1DE8
M344Z($EF($1#4R!I;F1I8V%T97,@1U--(&-H87)S970L(&%N9"!W92!G970@
M:70@:6X@8FEN87)Y+ I 0" M,34U,2PR,R K,34U-"PR-R! 0 H@(" @(" J
M(&QA8VL@=&AE;2X@($EF('1H97D@<VAO=6QD(&YO="!B92!D:7-C87)D960L
M('1H96X@=&AE(&-O9&4*(" @(" @*B!H86YD;&EN9R!S;7,@;65S<V%G97,@
M<VAO=6QD(&)E(')E=FEE=V5D+B @+2T@4D(@*B\*(" @("!I9B H(61E<W1I
M;F%T:6]N('Q\(&]C='-T<E]L96XH9&5S=&EN871I;VXI(#T](# I('L*+2 @
M(" @(" @:6YF;R@P+" B0TE-1#(Z($=O="!335,@=VET:&]U="!R96-E:79E
M<BP@9&ES8V%R9&EN9RXB*3L**R @(" @(" @:6YF;R@P+" B0TE-1#);)7-=
M.B!';W0@4TU3('=I=&AO=70@<F5C96EV97(L(&1I<V-A<F1I;F<N(BP**R @
M(" @(" @(" @(" @;V-T<W1R7V=E=%]C<W1R*&-O;FXM/FED*2D["B @(" @
M(" @(&=O=&\@97)R;W(["B @(" @?0H@(" @(&EF("@A;W)I9VEN('Q\(&]C
M='-T<E]L96XH;W)I9VEN*2 ]/2 P*2!["BT@(" @(" @(&EN9F\H,"P@(D-)
M340R.B!';W0@4TU3('=I=&AO=70@<V5N9&5R+"!D:7-C87)D:6YG+B(I.PHK
M(" @(" @("!I;F9O*# L(")#24U$,ELE<UTZ($=O="!335,@=VET:&]U="!S
M96YD97(L(&1I<V-A<F1I;F<N(BP**R @(" @(" @(" @(" @;V-T<W1R7V=E
M=%]C<W1R*&-O;FXM/FED*2D["B @(" @(" @(&=O=&\@97)R;W(["B @(" @
M?0H@"BT@(" @:68@*"@A=&5X="!\?"!O8W1S=')?;&5N*'1E>'0I(#T](# I
M("8F("@A541(('Q\(&]C='-T<E]L96XH541(*2 ]/2 P*2D@>PHM(" @(" @
M("!I;F9O*# L(")#24U$,CH@1V]T(&5M<'1Y(%--4RP@:6=N;W)I;F<N(BD[
M"BL@(" @:68@*"%T97AT("8F("@A541(('Q\(&]C='-T<E]L96XH541(*2 ]
M/2 P*2D@>PHK(" @(" @("!I;F9O*# L(")#24U$,ELE<UTZ($=O="!E;7!T
M>2!335,L(&EG;F]R:6YG+B(L"BL@(" @(" @(" @(" @(&]C='-T<E]G971?
M8W-T<BAC;VYN+3YI9"DI.PH@(" @(" @("!G;W1O(&5R<F]R.PH@(" @('T*
M+0HK(" @( H@(" @(&UE<W-A9V4@/2!M<V=?8W)E871E*'-M<RD["B @(" @
M:68@*"$@9&-S7W1O7V9I96QD<R@F;65S<V%G92P@1$-3*2D@>PH@"2\J(%A8
M6"!3:&]U;&0@<F5J96-T('1H:7,@;65S<V%G92 _("HO"BT)9&5B=6<H(D-)
M340R(BP@,"P@(DEN=F%L:60@1$-3(BD["BL@(" @(" @(&1E8G5G*")B8BYS
M;7,N8VEM9#(B+" P+" B0TE-1#);)7-=.B!);G9A;&ED($1#4R(L"BL@(" @
M(" @(" @(" @(&]C='-T<E]G971?8W-T<BAC;VYN+3YI9"DI.PH@"61C<U]T
M;U]F:65L9',H)FUE<W-A9V4L(# I.PH@(" @('T*(" @("!T:6UE*"9M97-S
M86=E+3YS;7,N=&EM92D["D! ("TQ-3DT+#$X("LQ-C Q+#(V($! "B @(" @
M4')I=D1A=&$@*G!D871A(#T@8V]N;BT^9&%T83L*(" @("!-<V<@*FUE<W-A
M9V4@/2!.54Q,.PH@"BT@(" @+RH@5$]$3SH@0VAE8VL@:68@=&AE('-E<75E
M;F-E(&YU;6)E<B!O9B!T:&ES(')E<75E<W0@:7,@=VAA="!W90HM(" @(" J
M(&5X<&5C=&5D+B J+PHM"BT@(" @:68@*')E<75E<W0M/F]P97)A=&EO;B ]
M/2!$14Q)5D527U-405154U]215!/4E0I('L*+2 @(" @(" @;65S<V%G92 ]
M(&-I;60R7V%C8V5P=%]D96QI=F5R>5]R97!O<G1?;65S<V%G92AR97%U97-T
M+"!C;VYN*3L*+2 @(" @(" @:68@*&UE<W-A9V4I"BT@(" @(" @(" @("!L
M:7-T7V%P<&5N9"AP9&%T82T^<F5C96EV960L(&UE<W-A9V4I.PHM(" @("!]
M"BT@(" @(&5L<V4@:68@*')E<75E<W0M/F]P97)A=&EO;B ]/2!$14Q)5D52
M7TU%4U-!1T4I('L*+2 @(" @(" @(&UE<W-A9V4@/2!C:6UD,E]A8V-E<'1?
M;65S<V%G92AR97%U97-T+&-O;FXI.PHM(" @(" @(" @:68@*&UE<W-A9V4I
M"BT@(" @(" @(" @(" @;&ES=%]A<'!E;F0H<&1A=&$M/G)E8V5I=F5D+"!M
M97-S86=E*3L**R @("!I9B H*')E<75E<W0M/G-E<2 ]/2 R-30@)B8@<&1A
M=&$M/G)E8V5I=F5?<V5Q(#T](# I('Q\"BL@(" @(" @(" @("!R97%U97-T
M+3YS97$@/3T@<&1A=&$M/G)E8V5I=F5?<V5Q("T@,BD@>PHK(" @(" @("!W
M87)N:6YG*# L(")#24U$,ELE<UTZ(')E<75E<W0@:&%D('-A;64@<V5Q=65N
M8V4@;G5M8F5R(&%S('!R979I;W5S+B(L"BL@(" @(" @(" @(" @(" @;V-T
M<W1R7V=E=%]C<W1R*&-O;FXM/FED*2D["BL@(" @?0HK(" @(&5L<V4@>PHK
M(" @(" @("!P9&%T82T^<F5C96EV95]S97$@/2!R97%U97-T+3YS97$@*R R
M.PHK(" @(" @("!I9B H<&1A=&$M/G)E8V5I=F5?<V5Q(#X@,C4T*0HK(" @
M(" @(" @(" @<&1A=&$M/G)E8V5I=F5?<V5Q(#T@,#L**PHK(" @(" @("!I
M9B H<F5Q=65S="T^;W!E<F%T:6]N(#T]($1%3$E615)?4U1!5%537U)%4$]2
M5"D@>PHK(" @(" @(" @(" @;65S<V%G92 ](&-I;60R7V%C8V5P=%]D96QI
M=F5R>5]R97!O<G1?;65S<V%G92AR97%U97-T+"!C;VYN*3L**R @(" @(" @
M(" @(&EF("AM97-S86=E*0HK(" @(" @(" @(" @(" @(&QI<W1?87!P96YD
M*'!D871A+3YR96-E:79E9"P@;65S<V%G92D["BL@(" @(" @('T**R @(" @
M(" @96QS92!I9B H<F5Q=65S="T^;W!E<F%T:6]N(#T]($1%3$E615)?3453
M4T%'12D@>PHK(" @(" @(" @(" @;65S<V%G92 ](&-I;60R7V%C8V5P=%]M
M97-S86=E*')E<75E<W0L8V]N;BD["BL@(" @(" @(" @("!I9B H;65S<V%G
M92D**R @(" @(" @(" @(" @("!L:7-T7V%P<&5N9"AP9&%T82T^<F5C96EV
M960L(&UE<W-A9V4I.PHK(" @(" @("!]"B @(" @?0H@"B @(" @8VEM9#)?
M<V5N9%]R97-P;VYS92AR97%U97-T+"!P9&%T82D["D! ("TQ-C,W+#$P("LQ
M-C4R+#8@0$ *(" @("!G=U]A<W-E<G0H<F5Q=65S=" A/2!.54Q,*3L*(" @
M("!G=U]A<W-E<G0H;W!E<F%T:6]N7V-A;E]S96YD*')E<75E<W0M/F]P97)A
M=&EO;BDI.PH@"BT@(" @9&5B=6<H(F)B+G-M<RYC:6UD,B(L(# L(")#24U$
M,ELE<UTZ('-E;F1I;F<@/"5S/B(L"BT@(" @(" @(" @;V-T<W1R7V=E=%]C
M<W1R*&-O;FXM/FED*2P*+2 @(" @(" @("!O8W1S=')?9V5T7V-S='(H<F5Q
M=65S="T^9&%T82DI.PHM"B @(" @:68@*'!D871A+3YS;V-K970@/" P*2![
M"B @(" @(" @('=A<FYI;F<H,"P@(D-)340R6R5S73H@8VEM9#)?<F5Q=65S
M=#H@<V]C:V5T(&YO="!O<&5N+B(L"B @(" @(" @(" @(" @(" @;V-T<W1R
M7V=E=%]C<W1R*&-O;FXM/FED*2D["D! ("TQ-C4Q+#8@*S$V-C(L,3 @0$ *
M(" @("!P86-K971?<V5T7W-E;F1?<V5Q=65N8V4H<F5Q=65S="P@<&1A=&$I
M.PH@(" @('!A8VME=%]S971?8VAE8VMS=6TH<F5Q=65S="D["B **R @("!D
M96)U9R@B8F(N<VUS+F-I;60R(BP@,"P@(D-)340R6R5S73H@<V5N9&EN9R \
M)7,^(BP**R @(" @(" @("!O8W1S=')?9V5T7V-S='(H8V]N;BT^:60I+ HK
M(" @(" @(" @(&]C='-T<E]G971?8W-T<BAR97%U97-T+3YD871A*2D["BL*
M(" @("!R970@/2!O8W1S=')?=W)I=&5?=&]?<V]C:V5T*'!D871A+3YS;V-K
M970L(')E<75E<W0M/F1A=&$I.PH@(" @(&EF("AR970@/" P*0H@(" @(" @
M("!G;W1O(&EO7V5R<F]R.PI 0" M,38V.2PW("LQ-C@T+#<@0$ *(" @(" @
M(" @;V-T<W1R7V1U;7 H<F5P;'DM/F1A=&$L(# I.PH@(" @(" @(" O*B!#
M;W)R96-T('-E<75E;F-E(&YU;6)E<B!I9B!S97)V97(@<V%Y<R!I="!W87,@
M=W)O;F<L"B @(" @(" @(" J(&)U="!O;FQY(&EF('-E<G9E<B=S(&YU;6)E
M<B!I<R!S86YE+B J+PHM(" @(" @("!I9B H<F5P;'DM/G-E<2 A/2!R97%U
M97-T+3YS97$@)B8@*')E<&QY+3YS97$@)2 Q*2 ]/2 Q*2!["BL@(" @(" @
M(&EF("AR97!L>2T^<V5Q("$](')E<75E<W0M/G-E<2 F)B H<F5P;'DM/G-E
M<2 E(#(I(#T](#$I('L*(" @(" @(" @(" @('=A<FYI;F<H,"P@(D-)340R
M6R5S73H@8V]R<F5C=&EN9R!S97%U96YC92!N=6UB97(@9G)O;2 E;&0@=&\@
M)6QD+B(L"B @(" @(" @(" @(" @(" @(" @(&]C='-T<E]G971?8W-T<BAC
M;VYN+3YI9"DL"B @(" @(" @(" @(" @(" @(" @("AL;VYG*2!P9&%T82T^
M<V5N9%]S97$L( I 0" M,3@V-RPW("LQ.#@R+#<@0$ *('L*(" @("!0<FEV
M1&%T82 J<&1A=&$@/2!C;VYN+3YD871A.PH@(" @('-T<G5C="!P86-K970@
M*G!A8VME=#L*+2 @("!/8W1S='(@*G1S.PHK(" @($]C='-T<B J=',@/2!.
M54Q,.PH@(" @(&EN="!R970["B *(" @("!G=U]A<W-E<G0H<&1A=&$@(3T@
'3E5,3"D["B @
`
end