Re: BUG+FIX - panic in octstr.c

Andreas Fink schrieb:
> 
> On Donnerstag, Juni 12, 2003, at 05:24 Uhr, Paul Keogh wrote:
> 
>      Function is convert() in gwlib/octstr.c
> 
>      Offending code is;
> 
>      ...
>      case 'E':
>      new = octstr_duplicate(va_arg(VALST(args), Octstr *));
>      if (!new)
>      new = octstr_imm("(null)");
>      octstr_url_encode(new);
>      ...
> 
>      You can't pass an immutable Octstr instance to the octstr_url_encode()
>      function.
> 
> how about octstr "manipulation" making a copy of the immutable once it has to be "modified"?

hmm, that would require to change octstr_url_encode() itself. And even
maybe more functions to check if they "could" receive immutable
octstrs. 

I'm +1 for Paul's suggestion to _create() the octstr is it's NULLed
from the _duplicate().

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are