Re: [PATCH] radius accounting proxy

Alexander,

make install issue fixed. thanks.



Alexander Malysh wrote:

>Sorry, attached patch doesn't work.. Please ignore it...
>
>On Wednesday 15 October 2003 11:58, Alexander Malysh wrote:
>  
>
>>Hi David,
>>
>>make install fixed in cvs, please try it. Thanks for pointing...
>>
>>Unfortunately, I'm not a wap expert :( I guess, it's just a typo, so please
>>try attached patch... Please report if it works and I will commit it
>>then...
>>
>>On Wednesday 15 October 2003 08:57, David Chkhartishvili wrote:
>>    
>>
>>>Hi Alexander,
>>>
>>>I've just tried latest CVS and got errors from 'make install':
>>>
>>>./install-sh -c -d /usr/local/kannel-rad2/include/kannel/gwlib
>>>(cd gwlib && find . -type f -name "*.h" | while read a ; do ./install-sh
>>>-c -m 644 $a /usr/local/kannel-rad2/include/kannel/gwlib ; done)
>>>/bin/sh: ./install-sh: not found
>>>      
>>>
>>[snip]
>>
>>    
>>
>>>also, I've experienced wapbox misbehavour:
>>>
>>>2003-10-15 11:48:08 [8] DEBUG: WSP: Converting from <text/vnd.wap.wml>
>>>to <application/vnd.wap.wmlc>
>>>2003-10-15 11:48:08 [8] DEBUG: WBXML: Encoding with wbxml version <1.3>
>>>2003-10-15 11:48:08 [8] DEBUG: WBXML: WML with ExternalID
>>><-//WAPFORUM//DTD WML 1.1//EN>
>>>2003-10-15 11:48:08 [8] DEBUG: WSP: Content-type is now
>>><application/vnd.wap.wmlc>, size 114 bytes (before: 333 bytes), content
>>>body is:
>>>2003-10-15 11:48:08 [8] DEBUG: Octet string at 124a28:
>>>2003-10-15 11:48:08 [8] DEBUG:   len:  114
>>>2003-10-15 11:48:08 [8] DEBUG:   size: 115
>>>2003-10-15 11:48:08 [8] DEBUG:   immutable: 0
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 03 04 6a 00 7f e7 55 03 63 61 72
>>>64 30 00 36 03   ..j...U.card0.6.
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 4d 61 67 74 69 20 47 53 4d 00 01
>>>e0 07 01 ae 32   Magti GSM......2
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 03 6c 6f 67 6f 31 2e 77 62 6d 70
>>>00 0c 03 4d 61   .logo1.wbmp...Ma
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 67 74 69 47 53 4d 2e 2e 2e 00 01
>>>26 dc 4a 03 67   gtiGSM.....&.J.g
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 65 6f 2e 77 6d 6c 00 01 03 47 65
>>>6f 72 67 69 61   eo.wml...Georgia
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 6e 00 01 26 dc 4a 03 65 6e 2f 69
>>>6e 64 65 78 2e   n..&.J.en/index.
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 77 6d 6c 00 01 03 45 6e 67 6c 69
>>>73 68 00 01 01   wml...English...
>>>2003-10-15 11:48:08 [8] DEBUG:   data: 01
>>>01                                             ..
>>>2003-10-15 11:48:08 [8] DEBUG: Octet string dump ends.
>>>2003-10-15 11:48:08 [8] DEBUG: WSP: Setting Referer URL to
>>><http://wap.magtigsm.ge/>
>>>2003-10-15 11:48:08 [8] WARNING: WSP: content-type
>>><application/vnd.wap.wmlc> not supported
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: machine 124600, state CONNECTED,
>>>event S-MethodResult.req
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: method 3, state PROCESSING, event
>>>S-MethodResult.req
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `text/plain', WSP
>>>version 1.2 to binary representation `0x0003'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `Date', WSP version
>>>1.2 to binary representation `0x0012'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `Server', WSP version
>>>1.2 to binary representation `0x0026'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `Last-Modified', WSP
>>>version 1.2 to binary representation `0x001d'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `ETag', WSP version
>>>1.2 to binary representation `0x0013'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `Accept-Ranges', WSP
>>>version 1.2 to binary representation `0x0004'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `Content-Length', WSP
>>>version 1.2 to binary representation `0x000d'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP: Mapping string `Content-Type', WSP
>>>version 1.2 to binary representation `0x0011'.
>>>2003-10-15 11:48:08 [2] DEBUG: WSP 0/3: New method state REPLYING
>>>2003-10-15 11:48:08 [2] DEBUG: WSP 0: New state CONNECTED
>>>2003-10-15 11:48:08 [6] DEBUG: WTP: resp_machine 3, state RESULT_WAIT,
>>>event TR-Result.req.
>>>2003-10-15 11:48:08 [6] DEBUG: WTP: begin_sar_result(): data len = 74
>>>2003-10-15 11:48:08 [6] DEBUG: WTP: dispath_to_wdp(): psn = 0
>>>2003-10-15 11:48:08 [6] DEBUG: WTP 32003-10-15 11:48:08 [16] DEBUG:
>>>boxc_receiver: got wdp from wapbox
>>>
>>>: New state RESULT_RESP_WAIT
>>>
>>>2003-10-15 11:48:08 [10] DEBUG: udp: sending message
>>>2003-10-15 11:48:09 [9] DEBUG: datagram received
>>>
>>>Alexander Malysh wrote:
>>>      
>>>
>>>>Hi Slava,
>>>>
>>>>just commited to cvs...
>>>>
>>>>Thanks.
>>>>
>>>>On Thursday 09 October 2003 13:24, Vjacheslav Chekushin wrote:
>>>>        
>>>>
>>>>>Hi, list.
>>>>>
>>>>>Numerous memory leaks are patched in radius accounting proxy.
>>>>>
>>>>>
>>>>>PS:
>>>>>It could be nice if developers before commiting something into cvs
>>>>>check code against memory leaks. It is quite simple:
>>>>>./configure with-malloc=check,
>>>>>compile, run in test enviroment. Stop.
>>>>>Now, if in log files you see:
>>>>>
>>>>>2003-10-08 13:23:54 [0] DEBUG: Current allocations: 0 areas, 0 bytes
>>>>>
>>>>>then everything is Ok, but if you see something like:
>>>>>
>>>>>2003-10-08 11:40:57 [0] DEBUG: Area 0x8271768, size 16, max_size 16
>>>>>2003-10-08 11:40:57 [0] DEBUG: Allocated by udp_recvfrom() at
>>>>>gwlib/socket.c:733 2003-10-08 11:40:57 [0] DEBUG: Claimed by
>>>>>udp_recvfrom() at gwlib/socket.c:733 2003-10-08 11:40:57 [0] DEBUG:
>>>>>Contents of area (first 16 bytes):
>>>>>2003-10-08 11:40:57 [0] DEBUG:   48 a2 26 08 10 00 00 00 11 00 00 00 00
>>>>>00 00 00
>>>>>
>>>>>2003-10-08 11:40:57 [0] DEBUG: Area 0x8271d18, size 16, max_size 16
>>>>>2003-10-08 11:40:57 [0] DEBUG: Allocated by radius_attr_pack() at
>>>>>radius/radius_pdu.c:156
>>>>>2003-10-08 11:40:57 [0] DEBUG: Claimed by radius_attr_pack() at
>>>>>radius/radius_pdu.c:156
>>>>>2003-10-08 11:40:57 [0] DEBUG: Contents of area (first 16 bytes):
>>>>>2003-10-08 11:40:57 [0] DEBUG:   00 00 00 00 00 00 00 00 00 00 00 00 00
>>>>>00 00 00
>>>>>
>>>>>2003-10-08 11:59:25 [0] DEBUG: Area 0x82d12d8, size 16, max_size 16
>>>>>2003-10-08 11:59:25 [0] DEBUG: Allocated by update_tables() at
>>>>>radius/radius_acct.c:84
>>>>>2003-10-08 11:59:25 [0] DEBUG: Claimed by update_tables() at
>>>>>radius/radius_acct.c:84 2003-10-08 11:59:25 [0] DEBUG: Contents of area
>>>>>(first 16 bytes):
>>>>>2003-10-08 11:59:25 [0] DEBUG:   e8 a7 2d 08 0d 00 00 00 0e 00 00 00 00
>>>>>00 00 00
>>>>>
>>>>>Then something is wrong and memory leaks are exists.
>>>>>          
>>>>>
>
>  
>


-- 
David Chkhartishvili
Tel: 995 99 182418