Re: PANIC: gwlib/octstr.c ...

Alexander Malysh wrote:
> 
> On Tuesday 11 November 2003 13:44, Stipe Tolj wrote:
> > Alexander Malysh wrote:
> > > Hi Igor,
> > >
> > > ++1 for this patch...
> > > It's 100% wrong to use octstr_imm for non const c-strings. And this can
> > > also explain why we have seen panics with "too many immutable octstr"...
> >
> > so, is there any need in changing code at different other places?
> 
> I would say - yes, or at least review should be made...
> 
> >
> > ie. gw/wap_push_pap_mime.c:drop_optional_header()
> 
> no, not there.
> This function is static and called only with:
>     if (drop_optional_header(body_part, "Content-Transfer-Encoding:") == 0)
>         return 0;
>     if (drop_optional_header(body_part, "Content-ID:") == 0)
>         return 0;
>     if (drop_optional_header(body_part, "Content-Description:") == 0)
> 
> means only with static c-strings and it's fine...

ok, so we'll have to backtrace the calls to see if non static
c-strings have been passed. I'll volonteer on this.

Stipe

mailto:[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:[email protected]
http://www.wapme-systems.de/
-------------------------------------------------------------------

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.2.2 (Cygwin)

mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-----END PGP PUBLIC KEY BLOCK-----