Re: [PATCH] Fix for kannel-monitor
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
Angel Fradejas wrote: > > Attached a patch to fix broken functionality (caused by fread()'s > bad behaviour) in kannel-monitor script. > > We have observed that with only one call to fread($buffer,200000), > the script does not receive the entire xml status document, for > documents bigger than 10K aproximately. It only receives something > in the 2000-5000 bytes range. > > So the symthom is that the smsc links summary says, for example, 48 > total links, only 5 online, and 0 > disconnected/connecting/reconnecting. > > I have confirmed this behaviour both with Apache/2.0.45 PHP/4.3.3 > and Apache/1.3.27 PHP/4.3.3 combinations. > > This patch has a safer way to be sure to read the entire xml > document, as feof() seems to be more reliable than fread() alone. definetly +1, Thanks a lot! -- commited to cvs. Stipe mailto:[email protected] ------------------------------------------------------------------- Wapme Systems AG Münsterstr. 248 40470 Düsseldorf, NRW, Germany phone: +49.211.74845.0 fax: +49.211.74845.299 mailto:[email protected] http://www.wapme-systems.de/ ------------------------------------------------------------------- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.2 (Cygwin) mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2 nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H g2HyLAEKQIp30Q== =aYCI -----END PGP PUBLIC KEY BLOCK-----