Re: Bug in wsp_server_method_states.def

Hi Pail,

> I think this code is wrong.
> 
>                 /*
>                  * The Siemens S35 adds an extra NUL character to the
> end
>                  * of the request body which may not work with certain
> cgi
>                  * scripts. It is removed here by truncating the length.
>                  */
>                 req_body_size = octstr_len(pdu->u.Post.data);
>                 if(octstr_get_char(pdu->u.Post.data,(req_body_size - 1))
> == 0)
>                         octstr_truncate(pdu->u.Post.data,(req_body_size
> - 1));
> 
> I posted in an MMS message where the last byte of the encoding was 0.
> This
> code truncated the last byte and corrupted the MMS message.
> 
> I suggest that "certain cgi scripts" be made more robust rather than
> hacking bytes out of the lower layers.

hmm, did you use a specific handset for this where it corrupts?!

This thing works for me with various devices and does not corrupt MMS
messages. 
Can you explain a bit more in details, please?!

Stipe

mailto:[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:[email protected]
http://www.wapme-systems.de/
-------------------------------------------------------------------

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.2.2 (Cygwin)

mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-----END PGP PUBLIC KEY BLOCK-----