Re: Bug in smpp_pdu.c ?

On Friday 20 February 2004 17:47, Paul Keogh wrote:
> > you're right it's a bug and this is known one.
> > for example see Thread with subject:
> > [Delivery reports not working in latest CVS using SMPP 3.4 to
> > logica SMSC]
>
> Thanks, I had a look at this. But there's 2 separate problems.
>
> * The SMPP driver should look for the SMPP_receipted_message_id opt
> param
> (when using 3.4) in DELIVER_SMs that contain reports. This is
> missing functionality, but the underlying smpp_pdu_unpack()
> works fine.

yep, that works fine...

>
> * The smpp_pdu_pack() is broken for optional parameters.

for packinng of opt. params we should know a type of them (e.g. 
integer/octsr/c-string). unfortunately this info is not present in our opt. 
params description (see smpp_pdu_opt.def) and IMO it's bad to store opt. 
params as a hash, because tooo heavy to access needed values...

I propose to change pack/unpack/handling of opt. params as follow:
1) extend smpp_pdu_opt.def in order to reflect type of the opt. param
2) define with help of preprocessor magic struct's for opt. params, similar to 
mandatory params (as undef. value '-1' for int, NULL for C-string/Octstr)


-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: [email protected]
web: www.centrium.de
msn: [email protected]
icq: 98063111
___________________________________________

Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html