Re: [PATCH] bb_smscconn.c (new patch)

Hi,

commited to cvs (with fixed memleak).

On Sunday 07 March 2004 19:28, Alexander Malysh wrote:
> Hi,
>
> On Sunday 07 March 2004 18:41, Nisan Bloch wrote:
> > Hi
> >
> > but the way it is at the moment it causes bearerbox to crash while trying
> > to access the NULL conn pointer
>
> then me must check for NULL pointer but not just silently drop message
> because "we were too lazy" to check this...
>
> Please test/comment attached patch.
>
> > nisan
> >
> > At 03:21 PM 2004/03/06, Alexander Malysh wrote:
> > >Hi,
> > >
> > >-1 from me for this patch.
> > >we want log failed messages into access log instead of just silently
> > > drop those.
> > >
> > >On Thursday 04 March 2004 23:09, Nisan Bloch wrote:
> > > > Hi
> > > >
> > > > A patch for bb_smscconn.c
> > > >
> > > > bb_smscconn.c:sms_router calls bb_smscconn_send_failed with a NULL
> > > > value for conn
> > > >        bb_smscconn_send_failed(NULL, msg, ................
> > > >
> > > > bb_smscconn_send_failed does not check for this and tries to use
> > > > conn.
> > > >
> > > > Nisan
> > >
> > >--
> > >Best regards / Mit besten Grüßen aus Düsseldorf
> > >
> > >Dipl.-Ing.
> > >Alexander Malysh
> > >___________________________________________
> > >
> > >Centrium GmbH
> > >Vogelsanger Weg 80
> > >40470 Düsseldorf
> > >
> > >Fon: +49 (0211) 74 84 51 80
> > >Fax: +49 (0211) 277 49 109
> > >
> > >email: a.malysh at centrium.de
> > >web: www.centrium.de
> > >msn: olek2002 at hotmail.com
> > >icq: 98063111
> > >___________________________________________
> > >
> > >Please avoid sending me Word, Excel or PowerPoint attachments.
> > >See http://www.fsf.org/philosophy/no-word-attachments.html

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: [email protected]
web: www.centrium.de
msn: [email protected]
icq: 98063111
___________________________________________

Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html