RE: [PATCH] bug# 000117: SMSBox crashes if %A is used in get-url

Sorry, I made those with TortoiseCVS to test that feature, instead of
running cvs diff from command line.
I'll check for that next time.

Angel FRADEJAS
Mediafusión España, S.A.
[email protected]
www.mediafusion.es
Tel. +34 91 252 3200
Fax  +34 91 252 5969
 

-----Mensaje original-----
De: [email protected] [mailto:[email protected]] En nombre de
Alexander Malysh
Enviado el: martes, 09 de marzo de 2004 0:16
Para: [email protected]
Asunto: Re: [PATCH] bug# 000117: SMSBox crashes if %A is used in get-url

Hi Angel,

urltrans_pattern_a.diff commited to cvs w/o modifications.
octstr_nulls.diff commited to cvs in slightly modified version.

BTW. Please run 'dos2unix' for your patches in future :)

Thanks a lot!

On Wednesday 03 March 2004 13:27, Angel Fradejas wrote:
> Forwarded to list for general review.
>
> Bug report by Bruno:
> %A is the text sent by SMSC when a Delivery Report arrives and doesn't
make
> sense in a get-url url, but nevertheless I've been reported that a %A in a
> get-url does crash kannel.
>
>
> My review:
> Tested and confirmed, there is no check for null in url_get_pattern() for
> the %A token.
> It is octstr_url_encode() which finally segfaults.
>
> I propose patches in two flavors to fix this:
>
> 1) the direct approach, patching urltrans.c, this fixes the bug without
> additional concerns.
>
> 2) a more "deep" patch, avoiding that
> octstr_(url_encode|url_decode|append|insert) segfault when receiving a
null
> Octstr*
>
> I think both two are very straightforward.
>
> Angel FRADEJAS
> Mediafusión España, S.A.
> [email protected]
> www.mediafusion.es <http://www.mediafusion.es/>
> Tel. +34 91 252 3200
> Fax  +34 91 252 5969

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: a.malysh (at) centrium.de
web: www.centrium.de
msn: a.malysh (at) centrium.de
icq: 98063111
___________________________________________

Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html