bb_alog.c - bug after last changes

"Robert Galach" <[email protected]> Wed, 10 Mar 2004 11:52:52 +0100

Newsgroups	gmane.comp.mobile.kannel.devel
Message-ID	<[email protected]>

hello all,
after long time I've updated my kannel version to current cvs :)

I found a bug after last commit in gw/bb_alog.c
There is a garbage in acces-log file if sms text contains e.g. "%d" text
and custom-access-log-format option is enabled with %b inside.

I guess this may cause seg fault in some cases, but it didn't happen to me.

Small patch  attached.

Regards
Robert GaÂłach

bb_alog_accesslog_garbage.patch (application/octet-stream, 520 B)

Index: gw/bb_alog.c
===================================================================
RCS file: /home/cvs/gateway/gw/bb_alog.c,v
retrieving revision 1.4
diff -u -r1.4 bb_alog.c
--- gw/bb_alog.c        8 Mar 2004 10:32:33 -0000       1.4
+++ gw/bb_alog.c        10 Mar 2004 10:38:26 -0000
@@ -375,7 +375,7 @@
         octstr_destroy(udh);
     } else {
         text = get_pattern(conn, sms, message);
-        alog(octstr_get_cstr(text));
+        alog("%s", octstr_get_cstr(text));
     }

     octstr_destroy(text);