Re: shared.c - splitted parts of long sms with same id

hi,

you are right, it is not needed
clean patch attached

----- Original Message ----- 
From: "Alexander Malysh" <[email protected]>
To: <[email protected]>
Sent: Wednesday, March 10, 2004 12:36 PM
Subject: Re: shared.c - splitted parts of long sms with same id


hi,

I believe that: uuid_clear(part->sms.id); is not needed?

On Wednesday 10 March 2004 12:23, Robert Galach wrote:
> hi again,
>
> I think there is one more bug, I found in current kannel cvs version.
>
> If long sms message is splitted (gw/shared.c:sms_split) every part created
> has the same id field,
> which is used to ACK/NACK comunication. It implies that acking first part
> by smsc,
> removes any other parts with that id from storefile and warnings at next
> acks.
>
> Patch attached.
>
> Regards
> Robert Gałach

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: [email protected]
web: www.centrium.de
msn: [email protected]
icq: 98063111
___________________________________________

Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

Index: gw/shared.c
===================================================================
RCS file: /home/cvs/gateway/gw/shared.c,v
retrieving revision 1.33
diff -u -r1.33 shared.c
--- gw/shared.c 16 Feb 2004 19:41:26 -0000      1.33
+++ gw/shared.c 10 Mar 2004 11:45:44 -0000
@@ -487,6 +487,8 @@
             part->sms.msgdata =
                 extract_msgdata_part_by_coding(temp, split_chars,
                                                max_part_len - nlsuf_len);
+            /* create new id for every part, except last */
+            uuid_generate(part->sms.id);
             last = 0;
         }
         if (header)