Re: [PATCH] xmlrpc missing features implementation

Hi Robert,

sorry but I'm too busy to review and vote :( please fill a bug report with 
this and other patches are you sent to ML...

Thanks in advance.

P.S. I will try to review those this weekend.

On Friday 19 March 2004 12:44, Robert Galach wrote:
> Hi,
> Could you guys look at the patch and vote?
> Stipe? Alex? What do you think about it?
>
> I've just received a patch that corrects parsing fault response,
>
> thank you Fred:
> > +++ gwlib/xmlrpc.c      2004-03-18 17:04:43.000000000 -0500
> > @@ -2567,9 +2567,9 @@
> >           */
> >          if (xmlrpc_value_get_type(value) != xr_struct ||
> >              (v_code = xmlrpc_get_member(value, octstr_imm("faultCode")))
>
> == NULL ||
>
> > -            xmlrpc_value_get_type(v_code) != xr_int ||
> > +            xmlrpc_value_get_type_smart(v_code) != xr_int ||
> >              (v_string = xmlrpc_get_member(value,
>
> octstr_imm("faultString"))) == NULL ||
>
> > -            xmlrpc_value_get_type(v_string) != xr_string ||
> > +            xmlrpc_value_get_type_smart(v_string) != xr_string ||
> >              xmlrpc_count_members(value) != 2) {
> >
> >              xrdoc->parse_status = XMLRPC_PARSING_FAILED;
> > @@ -2578,8 +2578,8 @@
> >              xmlrpc_value_destroy(value);
> >              return -1;
> >          }
> > -        fault->f_code = *(long *)xmlrpc_value_get_content(v_code);
> > -        fault->f_string = octstr_duplicate((Octstr
>
> *)xmlrpc_value_get_content(v_string));
>
> > +        fault->f_code = xmlrpc_scalar_get_int((XMLRPCScalar *)
>
> xmlrpc_value_get_content(v_code));
>
> > +        fault->f_string = xmlrpc_scalar_get_string((XMLRPCScalar *)
>
> xmlrpc_value_get_content(v_string));
>
> >          xmlrpc_value_destroy(value);
> >      } else {
> >
> > Fred Wittekind
> > eGIX SysAdmin
>
> Attached full patch again, but with above changes.
>
> Regards
> Robert

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: [email protected]
web: www.centrium.de
msn: [email protected]
icq: 98063111
___________________________________________

Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html