Re: [PATCH] dlr_mem.c & dlr_sdb.c check for dst

To answer part of my own question, it seems to me that the reason I
don't have the "+" character as part of the destination field of the dlr
is because the dlr destination field never passes through the
"normalize_number" function as the sender/receiver fields of mo/mt
messages do.

digging a bit deaper in the code shows that the normalization of the
destination dlr field might be best done in the "dlr_find" function.  of
course, this might break some people's dlr configurations.

anyone have any thoughts on this?  is modifying the dlr_find function to
normalize the dlr destination field a good or a bad idea?

nick



On Wed, 2004-03-31 at 10:32, Nicholas Rahn wrote:
> Hi,
> 
> This patch adds the check for the destination to dlr verification in
> internal and sdb storage.  As more than one sms can be sent with the
> same timestamp and smsc-id, these are not enough to ensure unicity of
> the dlrs.  So, as Robert Galach did for dlr_oracle.c, this patch adds
> the destination number to the check.  NOTE: mysql is now the only dlr
> storage that does not use this approach.
> 
> One thing i have noticed is that the CIMD2 smsc that i connect to
> accepts a destination number in international format (i.e. +41). 
> However, the dlr received back from the SMSC does not contain the "+"
> character.  So now (with my patch above :-), none of the received dlrs
> match!  Can anyone suggest a solution to this?
> 
> Thanks,
> nick
>