Re: [PATCH] dlr_mem.c & dlr_sdb.c check for dst

On Fri, 2004-04-02 at 11:50, Alexander Malysh wrote:
> On Friday 02 April 2004 11:49, Robert Galach wrote:
> > > 1) how want you guess a unified prefix in dlr_find when user has not
> >
> > supplied
> >
> > > unified prefix in the config file? (and that means user intervention).
> >
> > There is a way: normalize number to internal format in dlr_add also, before
> > insert to database.
> > (it could be even stripping prefix like in Alex magic)
> > I think that if there is a way to avoid "like" especially with '%' at the
> > beginning, it should be done.
> 
> -1, because you will loss a original destination in the DB.
> 
i have to agree with alex here.  if we normalize to internal format
before inserting into db, the number returned in %P of the dlr-url will
be unnormalized (unless we re-normalize it).

normalizing the number in dlr_find (before calling dlr_get) would
prevent any problems with number length.  
whether unified_prefix is specified or not can be taken care of just
like in bb_smscconn.c:252 (dlr_find must first be modified to have
access to unified_prefix from bb_smscconn and the conn->unified_prefix
in order to do full/correct normalization).

nick