Re: kannel smpp protocol

Hi Taras,

first of all: Please always add [email protected] in 'cc'!
next time we would prefer a patch against cvs...

Please try cvs version, I have just commited 'message_payload' handling.


On Monday 19 April 2004 14:46, Заец Тарас Петрович wrote:
> hello
>
> may i suggest а little fix for smpp protocol implementation in kannel
> project?... it's for compliance with smpp v 3.4 ...
> when i receive message by sms-service using interface-version=34, the
> short_message field is always empty and message_length = 0, because
> message text contained in message_payload field. (from smpp 3.4 doc:
> deliver_sm - ... Note: The message data should be inserted in either the
> short_message or the message_payload parameters. Both parameters must
> not be used simultaneously.)
>
>
> ./gw/smsc/smsc_smpp.c (starts from line 437 in 19.04 snapshot):
> ---search for---
>     msg->sms.msgdata = pdu->u.deliver_sm.short_message;
>     pdu->u.deliver_sm.short_message = NULL;
>     dcs_to_fields(&msg, pdu->u.deliver_sm.data_coding);
> --replace with---
>     if( pdu->u.deliver_sm.sm_length == 0 ||
> pdu->u.deliver_sm.short_message == NULL )
>       {
>         if( pdu->u.deliver_sm.message_payload != NULL )
>           {
>             // message text is in 'message_payload' field
>             msg->sms.msgdata = pdu->u.deliver_sm.message_payload;
>             pdu->u.deliver_sm.message_payload = NULL;
>           }
>         else
>           {
>             // empty message
>             msg->sms.msgdata = NULL;
>           }
>       }
>     else
>       {
>         // message text is in 'short_message' field
>         msg->sms.msgdata = pdu->u.deliver_sm.short_message;
>         pdu->u.deliver_sm.short_message = NULL;
>       }
>     dcs_to_fields(&msg, pdu->u.deliver_sm.data_coding);
> ---end---
>
> i test it on logica-cmg smsc using interface-version=34 in kannel.conf -
> it's work %)
>
> best regards
> ---
> Taras Zaets
> Mobile Telesystems, Moscow
> www.mtsgsm.com

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: a.malysh (at) centrium.de
web: www.centrium.de
msn: a.malysh (at) centrium.de
icq: 98063111
___________________________________________

Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAhEHcnX3e5W+uJ0ERAlbZAJ903FHBlBWPf1juhJ/QP5+GGm57KwCgyGm3
m/Djm2C3pHe4hqIIBZBNxyc=
=D8Hc
-----END PGP SIGNATURE-----