Re: WARNING: SMPP: PDU element <password> to long (length is 9, should be 9)

Ok, ok ... so how about some pacthes ;)

On Wed, 2004-08-11 at 10:24, Pedro B. wrote:
> Let alone the fact that "too long" is not spelled correctly. At least in 
> 10 locations of the code. and i only checked 4 .c files.
> 
> I'm sorry for what i'm about to say, but it's a proven fact:
> There is a vast amount of misspelling in both the old docs (that Stipe 
> aspelled, good stuff), and throughout all the code comments that shade a 
> very strong lack of credibility to Kannel.
> Everyone can make a typo, but if Kannel is really an english-based 
> product, there should be at least some being-elementary-school level of 
> spelling on all the code.
> The "english is not my mother language" is a feeble and worn out excuse 
> for a development team that (all except Bruno, according to the first 
> lines of the docs) is made of ceo's, directors, chiefs and the rest of 
> the "upper class management positions" plethora.
> 
> 
> \\pb
> 
> Alan McNatty wrote:
> 
> > Hi All,
> > 
> > Just checking - the SMPP password field can be max octets of 9 in
> > length. But when I set it to be 9 characters in length I get a  warning
> > that's it's too long, etc. 
> > 
> > My understanding of octets is not fantastic (like a C string - has a
> > null char which takes up 1?) so looking for some confirmation on what's
> > happening here (and maybe adjust the warning to be less confusing?).
> > Should the warning read 'should be 8'?
> > 
> > Cheers,
> > Alan
> > 
> > 
> > 2004-08-11 09:25:18 [12549] [14] DEBUG:   password: "PASSWORD1"
> > ...
> > 2004-08-11 09:25:18 [12549] [14] DEBUG: SMPP PDU dump ends.
> > 2004-08-11 09:25:18 [12549] [14] WARNING: SMPP: PDU element <password>
> > to long (length is 9, should be 9)
> > 
> 
> 
>