smpp - small patch (optional enhancement not bug)
Alan McNatty <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <1093239989.27534.6769.camel@euterpe> |
Hi All, Small scenario where a receipted_message_id is provided with no message_state (optional parameters). The attached patch changes current behaviour - fails the dlr, but rather falls through to try old style short_message (where some may succeed) before failing. Seems that some (SMSC) are slowly migrating to use optional parameters, just not all yet. I need this for one connection - could be added to HEAD if considered reasonable. Cheers, Alan
patch
(text/x-patch, 691 B)
Index: gw/smsc/smsc_smpp.c
===================================================================
RCS file: /home/cvs/gateway/gw/smsc/smsc_smpp.c,v
retrieving revision 1.71
diff -r1.71 smsc_smpp.c
974c974,977
< warning(0, "SMPP[%s]: Got DLR with unknown 'message_state' (%ld).",
---
>
> /* Rather than fail allow fall through to see if old style works */
> warning(0, "SMPP[%s]: Got DLR with unknown 'message_state' (%ld),"
> " falling through to do old style check.",
976c979,980
< dlrstat = DLR_FAIL;
---
>
> msgid = NULL;
988c992,993
< if (!msgid && respstr) {
---
> if (msgid == NULL && respstr) {
>