SMPP bug?

Hi,

One of our customers recently asked what this message "SMPP: PDU NUL
terminated string has no NUL." (smpp_pdu.c) in his Kannel log file meant. I
dug through the Kannel code & found that Kannel always expects a
submit_sm_resp to have a null terminated message_id field (smpp_pdu.def).

SMPP v3.4 specification, section 4.4.2 (submit_sm_resp) says :-

"The submit_sm_resp PDU Body is not returned if the command_status field
contains a non-zero value.".

Yes, amazingly, a mandatory field is actually not mandatory in some
circumstances. For several years, our SMPP SMSC always returned an empty
message_id (just a \0) when the submit_sm_resp header held an error, but
someone pointed out that this was wrong & that I should be returning only
the header. I checked some other large vendors smsc's & proved that this was
actually true, so I fixed our SMSC.

There's no logic in Kannel to differentiate success or non-success
submit_sm_resp.

I guess this is harmless. I don't actually use Kannel day to day. I assume
things will carry on as normal & this is purely a warning message?

--
Ian Cass