Re: [PATCH] improved store-file

On Fri, 2004-10-29 at 12:57, Alexander Malysh wrote:
> Hi Kalle,
> 
> some comments to your patch...
> 
> 1) don't use dict if you don't know how many items will be stored (dict
> filled to more as 80% works very slow). Here we should use something like
> red-black-tree.

Hm.. then this is a bit problematic. I really do not have time right now
to create new systems, so I have to think about this a bit more..


> 2) don't call any functions in signal handler that are not signal safe (you
> call gwthread_wakeup_all())
> 3) check for 'file != NULL' in 'int store_save(Msg *msg)'. Because file !=
> NULL is our marker for enabled store-file support (store-file support is
> optional).
> 
Thanks, fixed. I should have guessed that I have good reasons for doing
that 2) some years ago ;]


-- 
 &Kalle Marjola ::: Development ::: Helsinki ::: Enpocket