Re: [PATCH] http client timeouts part1 (v2)
Vjacheslav Chekushin <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | LMT |
| Message-ID | <[email protected]> |
Hi, Alexander. Patch looks good. I try to test it next week, but conceptually I am +1. (by the way, in conn_pool_get ifdef not needed IMHO). Alexander Malysh wrote: > second version of this patch (fixed double free bug). > > Alexander Malysh wrote: > > >>Hi, >> >>attached you can find path that fixes a problem with dead connections in >>http client connection pool. It's only a first part of fixes that we need >>(we still need to kill inactive connection after timeout expired). >> >>How it works is simple: >>1) before putting connection into connection pool register dummy callback >>2) if dummy callback called (we will receive error poll event) check if >>connection still ok and if not destroy it >>3) before return connection from pool, unregister dummy callback >> >>Comments/votes please! >> > -- Vjacheslav Chekushin mailto:[email protected] Latvian Mobile Phone Company http://www.lmt.lv