X-Kannel-Coding and %c incorrectly documented in userguide
Davy Chan <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
[Credit for observing the docs is out-of-date goes to Guillaume Cottenceau <[email protected]> ...] It appears that the X-Kannel-Coding and %c was not updated to reflect the "GREAT MIGRATION to -1 for SMS_PARAM_UNDEFINED". The document still states that the range for those two parameters are: 0 & 1: 7-bit 2 : 8-bit 3 : UCS-2 Everything in the source code suggests that X-Kannel-Coding and %c comes directly from msg->sms.coding which has the range of: 0: 7-bit 1: 8-bit 2: UCS-2 I've attached a patch to correct the CVS userguide.xml. See ya... d.c.
userguide.xml.diff
(text/plain, 2.5 KB)
*** userguide.xml.orig Thu Dec 02 14:35:33 2004
--- userguide.xml Thu Dec 02 16:10:54 2004
***************
*** 5766,5773 ****
</entry></row>
<row><entry><literal>%c</literal></entry><entry>
! message coding: 0 (default, 7 bits), 1 (7 bits),
! 2 (8 bits) or 3 (Unicode)
</entry></row>
<row><entry><literal>%C</literal></entry><entry>
--- 5766,5773 ----
</entry></row>
<row><entry><literal>%c</literal></entry><entry>
! message coding: 0 (default, 7 bits), 1 (8 bits),
! 2 (Unicode)
</entry></row>
<row><entry><literal>%C</literal></entry><entry>
***************
*** 5932,5943 ****
<entry><literal>X-Kannel-Compress</literal></entry></row>
<row><entry><literal>coding</literal></entry>
! <entry><literal>X-Kannel-Coding</literal>. If unset, defaults to 1
(7 bits) if <literal>Content-Type</literal> is <literal>text/plain
</literal>, <literal>text/html</literal> or
<literal>text/vnd.wap.wml</literal>. On
<literal>application/octet-stream</literal>, defaults to
! 8 bits (2). All other <literal>Content-Type</literal> values
are rejected.</entry></row>
<row><entry><literal>validity</literal></entry>
--- 5932,5946 ----
<entry><literal>X-Kannel-Compress</literal></entry></row>
<row><entry><literal>coding</literal></entry>
! <entry><literal>X-Kannel-Coding</literal>. If unset, defaults to 0
(7 bits) if <literal>Content-Type</literal> is <literal>text/plain
</literal>, <literal>text/html</literal> or
<literal>text/vnd.wap.wml</literal>. On
<literal>application/octet-stream</literal>, defaults to
! 8 bits (1). If <literal>Content-Type</literal> is
! <literal>text/plain</literal> and
! <literal>charset="UTF-16BE"</literal> then coding is 2.
! All other <literal>Content-Type</literal> values
are rejected.</entry></row>
<row><entry><literal>validity</literal></entry>
***************
*** 6032,6038 ****
<row><entry><literal>%c (coding)</literal></entry>
<entry><literal>X-Kannel-Coding</literal></entry>
! <entry>1=7 Bits, 2=8 Bits, 3=UCS2</entry></row>
<row><entry><literal>- (compress)</literal></entry>
<entry><literal>X-Kannel-Compress</literal></entry>
--- 6035,6041 ----
<row><entry><literal>%c (coding)</literal></entry>
<entry><literal>X-Kannel-Coding</literal></entry>
! <entry>0=7 Bits, 1=8 Bits, 2=UCS2</entry></row>
<row><entry><literal>- (compress)</literal></entry>
<entry><literal>X-Kannel-Compress</literal></entry>