Re: [patch] bearerbox acknowledged sendsms (fixed)

Hi Kalle,

On Wed, 2004-12-15 at 11:02 +0200, Kalle Marjola wrote:
> As there was debate on how this system should be used, this patch now
> introduces 'immediate-sendsms-reply' boolean config value for smsbox.
> As it is false by default, it means that this new behaviour is
> _default_ and is a compatibility breaker if sendsms callers check the
> exact body of the reply.

While thinking about sendsms-reply patch, I have just another idea.

For DLR messages, AFAIK, DLR records are removed from storage when the
related DLR message is received from SMSC and forwarded to smsbox.
smsbox replies to this event almost immediately and it seems like it
does not wait for the result of HTTP request to the specified dlr-url.

If the request to dlr-url fails, DLR record gets removed anyway; so we
end up with lost metadata, which is a little bit bad, as it seems.

PS: There's no attachment. Could you please attach it? :)
PS2: Your last commit caused these warnings:

        gw/bb_store.c: In function `store_dumper':
        gw/bb_store.c:206: warning: unused variable `match'
        gw/bb_store.c:205: warning: unused variable `ack'
        gw/bb_store.c: In function `store_load':
        gw/bb_store.c:450: warning: unused variable `id'
        gw/bb_store.c:449: warning: unused variable `store_size'
        gw/bb_store.c:446: warning: unused variable `dmsg'
        gw/bb_store.c: At top level:
        gw/bb_store.c:186: warning: `cmp_msgs' defined but not used

Thanks a lot,
-- 
Enver ALTIN                   |        http://skyblue.gen.tr/
Software developer @ Parkyeri |      http://www.parkyeri.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBBwBUFZCB2FZvqK0sRAkHZAJ4iceU8U3bMHYTz+kOsdKRpr+0pQACeJ++B
CrQnmusxA283fdziLGNmEhY=
=9YSh
-----END PGP SIGNATURE-----