RE: kannel-monitor patch: dead bb causes monitor to freeze

Further to your patch, I noticed when there is a bearerbox attached and no
smsbox's attached to it, the bearerbox doesn't appear in the Box
Connections. This is due to the test being an empty() test with a few spaces
in the variable $x... Doing a trim solved this..

Cheers,
Bill

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf
Of Alexander Malysh
Sent: 23 December 2004 11:13
To: [email protected]
Subject: RE: kannel-monitor patch: dead bb causes monitor to freeze

hi,

sorry for delay...

Patch commited to cvs, Thanks!

Agastiya S. Mohammad wrote:

> Hi,
> 
> I can not do that. I don't have commit access to CVS. AFAIK, this is 
> the right way to contribute patches.
> 
> rgds,
> Agastiya S. Mohammad
> 
> On Thu, 2004-12-23 at 01:05, Hillel Bilman wrote:
>> Hi,
>> 
>> Why don't you commit this to CVS?
>> 
>> Thanks
>> 
>> -----Original Message-----
>> From: [email protected] [mailto:[email protected]]On
>> Behalf Of Agastiya S. Mohammad
>> Sent: Monday, December 20, 2004 9:52 AM
>> To: Kannel Development list
>> Subject: kannel-monitor patch: dead bb causes monitor to freeze
>> 
>> 
>> Hi list,
>> 
>> I am using Stipe's kannel-monitor for daily use, and stumble into 
>> trouble when one of my bearerbox dead, the page do not show me the 
>> complete status of my other boxes.
>> 
>> I made some small changes to make this page robust. I am also 
>> interested in developing this monitor, if I may, of course. :D
>> 
>> rgds,
>> Agastiya S. Mohammad
>> FarOut Technologies
>> 
>>

--
Thanks,
Alex

--- index.php.231204    2004-12-23 12:09:48.000000000 +0000
+++ index.php   2004-12-23 12:10:09.000000000 +0000
@@ -301,6 +301,7 @@

         foreach ($configs as $inst => $config) {
             $x = XPathValue("gateway/boxes", $status[$inst]);
+            $x = trim($x); // the boxes number sometimes returns a few blank spaces
             /* drop an error in case we have no boxes connected */
             if (empty($x)) {
                         echo "<tr><td valign=top align=center class=text>\n";