Re: [PATCH] http server fixes

On Wed, 2005-01-19 at 16:36 +0100, Alexander Malysh wrote:
> Hi together,

Hi,

> - don't close listen filedescriptor when accept failed (that can be caused
> bei client just now disconnected or network error)
> - added 'active_list' that saves all active http clients and so while
> shutdown all active clients can be disconnected gracefully (w/o fdset
> warning about active entries) and when listen port removed all active
> clients for this port could be disconnected
> This active_list could be used later in order to implement keep alive
> timeout.

Rock! :) I have a (cosmetic) comment about a comment :)

>         +            /* Implicite conn_unregister() and _destroy */

                          ^^^^^^^^ -> Implicit

>         +            if (conn_error(conn))
>         +                goto error;

Looks great, and this is a _must_ for 1.4.1 I think.
-- 
Enver ALTIN                   |        http://skyblue.gen.tr/
Software developer @ Parkyeri |      http://www.parkyeri.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBB7oNCZCB2FZvqK0sRAtDyAJ98ksJ7M+zS+jVvT6BN74bPoJQteACfT6va
YVQyJPBsepWQJ/7OfBq+Fg0=
=BGek
-----END PGP SIGNATURE-----