Re: [PATCH] WSP headers with <end-of-string> value

Hi, all.

+1 from me


Just one comment.
This patch will be good as far as no any header with special treatment
for "No-value".
We unpack fields in wsp_unpack_well_known_field().
I checked that in current specs no any header with special hanling for
"No-value". But if it will be added, than this patch is

Stipe Tolj wrote:
 > Ok,
 >
 > regarding the Siemens SX1 kludge and the WSP headers with
 > <end-of-string> as only value byte, I'd like to get at least a vote for
 > commiting this patch from the following developers:
 >
 >   Aarno, Paul, Slava
 >
 > please.
 >
 > You guys haven't stated yet nothing regarding a vote. Please do so. I'd
 > like to keep it that way in order to have a negotiated consensus.
 >
 > Stipe
 >
 > mailto:stolj_{at}_wapme.de
 > -------------------------------------------------------------------
 > Wapme Systems AG
 >

 >
 > Index: wap/wsp_headers.c
 > ===================================================================
 > RCS file: /home/cvs/gateway/wap/wsp_headers.c,v
 > retrieving revision 1.19
 > diff -u -r1.19 wsp_headers.c
 > --- wap/wsp_headers.c	8 Aug 2004 20:39:56 -0000	1.19
 > +++ wap/wsp_headers.c	21 Jan 2005 01:11:50 -0000
 > @@ -110,7 +110,7 @@
 >      unsigned long len;
 >
 >      val = parse_get_char(context);
 > -    if (val >= 0 && val < 31) {
 > +    if (val > 0 && val < 31) {
 >          *well_known_value = -1;
 >          parse_limit(context, val);
 >          return WSP_FIELD_VALUE_DATA;
 > @@ -126,7 +126,7 @@
 >          *well_known_value = -1;
 >          /* We already consumed the Quote */
 >          return WSP_FIELD_VALUE_NUL_STRING;
 > -    } else {
 > +    } else {    /* implicite val == 0 */
 >          *well_known_value = -1;
 >          /* Un-parse the character we just read */
 >          parse_skip(context, -1);


-- 
Vjacheslav Chekushin                                mailto:[email protected]
Latvian Mobile Phone Company                        http://www.lmt.lv