Re: [PATCH] http client/server timeout

Hi,

Great work!

Definitly +1 for this approach.

Draft tests seems to works.

Alexander Malysh wrote:
> Hello together,
> 
> please find attached patch that implements http server & client idle
> timeout. In order to efficient handle timeouts and don't start "yet another
> thread" we use already available fdset's threads. With this patch applied
> we will have a possibility to set timeout for all filedescriptors in fdset
> and after timeout elapsed registered callback function with POLLERR as
> event will be called. I'm surprised with sooo little code change reach full
> working server/client timeout handling :)
> 
> Maybe we want implement (yet missing) things too:
> - dont wait for set->timeout instead find the min timeout (this part is not
> implemented yet because will cause parformance bust due to a need to rescan
> the whole fdset after all callbacks were executed and anyway for boxes with
> high traffic earlier timeout check will catch).
> - timeout for each fd (IMHO: it's oversized for our needs)
> 
> 
> Comments & votes please!
> 
> 
> 


-- 
Vjacheslav Chekushin                                mailto:[email protected]
Latvian Mobile Phone Company                        http://www.lmt.lv