Re: Potential problem with dlr-storage in core group

Alex Judd wrote:

> Thanks Alex - yes you're right - the --with-mysql and --with-mysql-directory
> configuration parameters fixed the issue.
> 
> Interestingly though I couldn't see any if/defs in the code to stop the
> check being valid as it was reporting in the tests?
> 
>     /*
>      * assume we are using internal memory in case no directive
>      * has been specified, warn the user anyway
>      */
>     if (dlr_type == NULL) {
>         dlr_type = octstr_imm("internal");
>         warning(0, "DLR: using default 'internal' for storage type.");
>     }
> 
>     /* call the sub-init routine */
>     if (octstr_compare(dlr_type, octstr_imm("mysql")) == 0) {
>         handles = dlr_init_mysql(cfg);
>     } else if (octstr_compare(dlr_type, octstr_imm("sdb")) == 0) {
>         handles = dlr_init_sdb(cfg);
>     } else if (octstr_compare(dlr_type, octstr_imm("oracle")) == 0) {
>         handles = dlr_init_oracle(cfg);
>     } else if (octstr_compare(dlr_type, octstr_imm("internal")) == 0) {
>         handles = dlr_init_mem(cfg);
>     } else if (octstr_compare(dlr_type, octstr_imm("pgsql")) == 0) {
>         handles = dlr_init_pgsql(cfg);
>     }

#ifdefs are directly inside gw/dlr_mysql.c that pass struct dlr_storage as 
result of the dlr_init_foobar calls.

Stipe

mailto:stolj_{at}_wapme.de
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
-------------------------------------------------------------------