Re: [PATCH] curl
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | The Kannel Group |
| Message-ID | <[email protected]> |
Paul P Komkoff Jr wrote:
> attached
ok, I may be picky again... but I'll be anyway ;)
As far as I understand, this means, libcurl support is optional via configure
switch --enable-curl, right?
Some points I'd like to see cleaned:
* moving curl_XXX functions to an "own" file instead of mudging it into
gw/wap-appl.c. This is not the appropriate place IMO.
* code style. See doc/CodingStyle for our "coding rules" ;)
Paul, if you could revise these point and re-submit a new patch, I'd be willing
to test directly and vote +1 for commiting. Mainly since this would imply that
libcurl support is OPTIONAL.
User's are legitim individuals to pick on their own, what they want.
Stipe
mailto:stolj_{at}_wapme.de
-------------------------------------------------------------------
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
-------------------------------------------------------------------