Re: [PATCH] curl
Dziugas Baltrunas <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi,
> As far as I understand, this means, libcurl support is optional via configure
> switch --enable-curl, right?
>
> Some points I'd like to see cleaned:
>
> * moving curl_XXX functions to an "own" file instead of mudging it into
> gw/wap-appl.c. This is not the appropriate place IMO.
>
> * code style. See doc/CodingStyle for our "coding rules" ;)
>
A snip from doc/CodingStyle:
Don't add new features and make them conditionally compiled.
Either add them completely, or don't add them at all.
Should it now be removed?
--
Dziugas