Re: [PATCH] curl

Davy Chan wrote:

> **>Subject: Re: [PATCH] curl
> **>From: Enver ALTIN <[email protected]>
> **>To: [email protected]
> **>In-Reply-To: <[email protected]>
> **>Organization: Parkyeri
> **>Date: Fri, 11 Feb 2005 18:09:19 +0200
> **>
> **>On Fri, 2005-02-11 at 16:38 +0200, Dziugas Baltrunas wrote:
> **>> A snip from doc/CodingStyle:
> **>> 
> **>>         Don't add new features and make them conditionally compiled.
> **>>         Either add them completely, or don't add them at all.
> **>> 
> **>> Should it now be removed?
> **>
> **>A very good catch. I think we should remove this.
> 
> I think this clause was to prevent cluttering the code with
> ifdef's that were not controlled by the configure process.
> 
> If taken without any context, then we would never have had Kannel
> support/not support SSL connections.

right. That was the main intention of the clause. I don't see an active reason 
to remove it. Seeing the clause in such a context in legitim and holds still 
with current policy on how to add optional features, IMO.

> Maybe Kalle could shed some light on the matter.

yep, Kalle may know it best. ;)

Stipe

mailto:stolj_{at}_wapme.de
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
-------------------------------------------------------------------